Skip to content

🔁 Add swipe actions to conversation list items #6185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 6 commits into from
May 13, 2026
Merged

🔁 Add swipe actions to conversation list items #6185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f349842
feat(convo-list): Add swipe actions for read/unread and leave room
AndyScherzinger May 12, 2026
8556f46
style(convo-list): Add subtle in-icon animation to swipe action icons
AndyScherzinger May 12, 2026
e136b55
style(convo-list): mark convos as read/unread optimistically but rese…
AndyScherzinger May 13, 2026
97d0454
style(convo-list): fav/unfav convos optimistically but reset+show err…
AndyScherzinger May 13, 2026
4a00f0e
fix(detekt): fix detekt issues
AndyScherzinger May 13, 2026
ba0ccb0
style: Fix detekt and ktlint issues
AndyScherzinger May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 17 additions & 31 deletions app/src/main/java/com/nextcloud/talk/conversationlist/ConversationsListActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,9 +462,6 @@ class ConversationsListActivity : BaseActivity() {
conversationsListViewModel.readUnreadState.collect { state ->
when (state) {
is ConversationsListViewModel.ConversationReadUnreadUiState.Success -> {
fetchRooms()
val resId = if (state.isMarkedRead) R.string.marked_as_read else R.string.marked_as_unread
showSnackbar(String.format(resources.getString(resId), state.conversationDisplayName))
conversationsListViewModel.resetReadUnreadState()
}
is ConversationsListViewModel.ConversationReadUnreadUiState.Error -> {
Expand All @@ -475,6 +472,21 @@ class ConversationsListActivity : BaseActivity() {
}
}
}

lifecycleScope.launch {
conversationsListViewModel.favoriteState.collect { state ->
when (state) {
is ConversationsListViewModel.FavoriteUiState.Success -> {
conversationsListViewModel.resetFavoriteState()
}
is ConversationsListViewModel.FavoriteUiState.Error -> {
showSnackbar(resources.getString(R.string.nc_common_error_sorry))
conversationsListViewModel.resetFavoriteState()
}
ConversationsListViewModel.FavoriteUiState.None -> { /* no-op */ }
}
}
}
}

private fun handleNoteToSelfShortcut(noteToSelfAvailable: Boolean, noteToSelfToken: String) {
Expand Down Expand Up @@ -1096,38 +1108,12 @@ class ConversationsListActivity : BaseActivity() {
}
}

@Suppress("Detekt.TooGenericExceptionCaught", "TooGenericExceptionCaught")
private fun addConversationToFavorites(conversation: ConversationModel) {
val apiVersion = ApiUtils.getConversationApiVersion(currentUser!!, intArrayOf(ApiUtils.API_V4, ApiUtils.API_V1))
val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser?.baseUrl!!, conversation.token)
lifecycleScope.launch {
try {
withContext(Dispatchers.IO) { ncApiCoroutines.addConversationToFavorites(credentials!!, url) }
fetchRooms()
showSnackbar(
String.format(resources.getString(R.string.added_to_favorites), conversation.displayName)
)
} catch (e: Exception) {
showSnackbar(resources.getString(R.string.nc_common_error_sorry))
}
}
conversationsListViewModel.addConversationToFavorites(conversation)
}

@Suppress("Detekt.TooGenericExceptionCaught", "TooGenericExceptionCaught")
private fun removeConversationFromFavorites(conversation: ConversationModel) {
val apiVersion = ApiUtils.getConversationApiVersion(currentUser!!, intArrayOf(ApiUtils.API_V4, ApiUtils.API_V1))
val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser?.baseUrl!!, conversation.token)
lifecycleScope.launch {
try {
withContext(Dispatchers.IO) { ncApiCoroutines.removeConversationFromFavorites(credentials!!, url) }
fetchRooms()
showSnackbar(
String.format(resources.getString(R.string.removed_from_favorites), conversation.displayName)
)
} catch (e: Exception) {
showSnackbar(resources.getString(R.string.nc_common_error_sorry))
}
}
conversationsListViewModel.removeConversationFromFavorites(conversation)
}

private fun markConversationAsUnread(conversation: ConversationModel) {
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/com/nextcloud/talk/conversationlist/data/OfflineConversationsRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ interface OfflineConversationsRepository {

suspend fun updateConversation(conversationModel: ConversationModel)

suspend fun updateConversationLocallyAndEmit(user: User, conversation: ConversationModel)

@Deprecated("use observeConversation")
suspend fun getLocallyStoredConversation(user: User, roomToken: String): ConversationModel?

Expand Down
6 changes: 6 additions & 0 deletions ...a/com/nextcloud/talk/conversationlist/data/network/OfflineFirstConversationsRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ class OfflineFirstConversationsRepository @Inject constructor(
dao.updateConversation(entity)
}

override suspend fun updateConversationLocallyAndEmit(user: User, conversation: ConversationModel) {
dao.updateConversation(conversation.asEntity())
val updatedList = getListOfConversations(user.id!!)
_roomListFlow.emit(updatedList)
}

override suspend fun getLocallyStoredConversation(user: User, roomToken: String): ConversationModel? {
val id = user.id!!
return getConversation(id, roomToken)
Expand Down
Loading
Loading