[stable-24.0] fix links#6236
Merged
Merged
Conversation
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Linkify.addLinks with a bitmask can clear existing URLSpans before adding its own. Running the URL regex after the phone/email pass caused the URL span to be wiped. Phone/email now runs first so the URL regex span is never overwritten. AI-assistant: 1.9.1-251 (GPT-5.2-Codex) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
The enableLinks flag flows correctly through the call chain. Regular messages (via EnrichedText) keep the default enableLinks = true so URLs and markdown links are clickable; quoted messages pass enableLinks = false so neither render as tappable links — tapping anywhere on the quote navigates to the original message instead. AI-assistant: 1.9.1-251 (GPT-5.2-Codex) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/26575320889/artifacts/7268028661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6193