[stable-24.0] fix: HPB partial updates no longer drop the call when a participant joins#6243
Merged
Merged
Conversation
…oins With external signaling (HPB), onParticipantsUpdate delivers partial updates containing only changed participants. The previous code treated both full lists (onUsersInRoom) and partial updates (onParticipantsUpdate) identically: any participant absent from the list was moved to the "left" collection. When a new participant joined via HPB, the local user was not included in the partial update. This caused the local participant to appear in "left", which made CallActivity think a moderator had ended the call for everyone and trigger hangup(). Fix: processParticipantList now takes a boolean fullList parameter. - onUsersInRoom passes fullList=true: absent participants have left (unchanged) - onParticipantsUpdate passes fullList=false: absent participants are still in the call and are moved to "unchanged" instead of "left" Fixes #5452 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alain Lauzon <alauzon@alainlauzon.com>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/26620406577/artifacts/7284025028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6087