Skip to content

refactor(title-bar): remove unneeded container for user menu#1579

Open
ShGKme wants to merge 1 commit into
mainfrom
refactor/UserMenu
Open

refactor(title-bar): remove unneeded container for user menu#1579
ShGKme wants to merge 1 commit into
mainfrom
refactor/UserMenu

Conversation

@ShGKme

@ShGKme ShGKme commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Mostly to remove the warning
  • Review with Ignore whitespace
image

@ShGKme ShGKme added this to the 🪴 Next Release milestone Dec 12, 2025
@ShGKme ShGKme self-assigned this Dec 12, 2025
@ShGKme ShGKme added 3. to review technical debt Maintenance and refactoring labels Dec 12, 2025

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

<UiMenuSeparator />

<UiMenuItem tag="a" :href="serverUrl" target="_blank">
<UiMenuItem key="custom-status" tag="button" @click="openUserStatusDialog">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we 'close-on-click' here, maybe?

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Works out of the box for me via `popper-hide-triggers`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... This is before this PR

2025-12-12_11h08_13.mp4

This is after

2025-12-12_11h11_31.mp4

Can take a look later

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a thing for me on Windows, only click outside works

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
ShGKme force-pushed the refactor/UserMenu branch from ab2d4ae to 3c07878 Compare July 9, 2026 20:51
@ShGKme

ShGKme commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author
  • Rebased
  • Review with "hide whitespaces"

@ShGKme ShGKme removed this from the 🌸 26 Spring milestone Jul 9, 2026

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise still good

<UiMenuSeparator />

<UiMenuItem tag="a" :href="serverUrl" target="_blank">
<UiMenuItem key="custom-status" tag="button" @click="openUserStatusDialog">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a thing for me on Windows, only click outside works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low technical debt Maintenance and refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants