perf(cleanup): Optimize fetching all document to cleanup

Do that in one query instead of ending up doing N+1 queries.

Signed-off-by: Carl Schwan <carlschwan@kde.org>

Author: CarlSchwan

lib/Cron/Cleanup.php

@@ -36,13 +36,7 @@ public function __construct(
 	 */
 	protected function run($argument): void {
 		$this->logger->debug('Run cleanup job for text documents');
-		foreach ($this->documentService->getAll() as $document) {
-			if ($this->sessionService->countAllSessions($document->getId()) > 0) {
-				// Do not reset if there are any sessions left
-				// Inactive sessions will get removed further down and will trigger a reset next time
-				continue;
-			}
-
+		foreach ($this->documentService->getAllWithNoActiveSession() as $document) {
 			try {
 				$this->documentService->resetDocument($document->getId());
 			} catch (DocumentHasUnsavedChangesException) {

lib/Db/DocumentMapper.php

@@ -54,6 +54,22 @@ public function findAll(): Generator {
 		}
 	}
 
+	public function findAllWithNoActiveSessions(): Generator {
+		$qb = $this->db->getQueryBuilder();
+		$result = $qb->select('d.*')
+			->from($this->getTableName(), 'd')
+			->leftJoin('d', 'text_sessions', 's', $qb->expr()->eq('s.document_id', 'd.id'))
+			->where($qb->expr()->isNull('s.id'))
+			->executeQuery();
+		try {
+			while ($row = $result->fetch()) {
+				yield $this->mapRowToEntity($row);
+			}
+		} finally {
+			$result->closeCursor();
+		}
+	}
+
 	public function countAll(): int {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select($qb->func()->count('id'))

lib/Service/DocumentService.php

@@ -463,6 +463,10 @@ public function getAll(): \Generator {
 		return $this->documentMapper->findAll();
 	}
 
+	public function getAllWithNoActiveSession(): \Generator {
+		return $this->documentMapper->findAllWithNoActiveSessions();
+	}
+
 	/**
 	 * @throws NotPermittedException
 	 * @throws NotFoundException