feat: Add experimental option to allow typing during connectivity issues or being offline#6933
Closed
juliusknorr wants to merge 1 commit into
Closed
feat: Add experimental option to allow typing during connectivity issues or being offline#6933juliusknorr wants to merge 1 commit into
juliusknorr wants to merge 1 commit into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6933 +/- ##
=======================================
Coverage 52.27% 52.28%
=======================================
Files 479 479
Lines 41736 41742 +6
Branches 1024 1024
=======================================
+ Hits 21819 21825 +6
Misses 19815 19815
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Should be good to go to main actually :) |
3c6fe90 to
0022e49
Compare
elzody
reviewed
Mar 24, 2025
0022e49 to
343bd85
Compare
343bd85 to
0182052
Compare
Collaborator
|
@juliusknorr I think you will also want to check for the flag in this watcher: text/src/components/Editor.vue Lines 360 to 367 in 0182052 |
0182052 to
74fd252
Compare
…ues or being offline Signed-off-by: Julius Knorr <jus@bitgrid.net>
74fd252 to
a319d90
Compare
Member
Author
|
@max-nextcloud I adjusted that. Do you think it makes sense to have that given that you focus more on this the next time? Or do you want to approach this differently? Could it still be useful for testing? I'd be fine to either merge or close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something to have merged so we can experiment on daily
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)