fix(ImageView): use cursor: pointer for clickable items#8813
Open
mejo- wants to merge 1 commit into
Open
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Also move the click handler for non-image attachments from the full-width container box to the attachment box with a visible boundary. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/attachments_cursor
branch
from
07f3bfe to
f8096ec
Compare
Comment on lines
+27
to
+29
| <div | ||
| class="media__wrapper clickable" | ||
| @click="handleAttachmentClick"> |
Collaborator
There was a problem hiding this comment.
How about using an <a> tag instead. That seems semantically closer to what the element is.
The href could even point to the url handleAttachmentClick opens if it does not open the viewer.
| :src="imageUrl" | ||
| :alt="alt" | ||
| class="image__main" | ||
| class="image__main clickable" |
Collaborator
There was a problem hiding this comment.
Maybe also turn the surounding <div> into an <a> and move the click handler there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also move the click handler for non-image attachments from the full-width container box to the attachment box with a visible boundary.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)