chore(refactor): loop over possible footnotes once#8876
Merged
Conversation
Cache the `referenceLabels` so we do not need to loop over all descendants twice. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/footnote_followup_alternative
branch
from
July 14, 2026 09:05
5aea729 to
d1b6016
Compare
mejo-
approved these changes
Jul 14, 2026
mejo-
left a comment
mejo-
left a comment
Member
There was a problem hiding this comment.
Much cleaner indeed, thank you ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially cached the
referenceLabelsin case there are multiplefootnotesnodes.But that increased complexity quite a bit and seems like an unneccessary optimization.