Skip to content

chore(refactor): loop over possible footnotes once #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 1 commit into from
Jul 14, 2026
+7 −18
Merged

chore(refactor): loop over possible footnotes once #8876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions src/nodes/Footnotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,30 +83,19 @@ const Footnotes = Node.create({
return null
}

let hasFootnotes = false
for (let i = 0; i < newState.doc.childCount; i++) {
if (newState.doc.child(i).type.name === 'footnotes') {
hasFootnotes = true
break
}
}
if (!hasFootnotes) {
return null
}

const referencedLabels = new Set<string>()
newState.doc.descendants((node) => {
if (node.type.name === 'footnoteReference') {
referencedLabels.add(node.attrs.referenceId)
}
})

const deletions: { pos: number, size: number }[] = []
newState.doc.forEach((child, offset) => {
if (child.type.name !== 'footnotes') {
return
}

const referencedLabels = new Set<string>()
newState.doc.descendants((node) => {
if (node.type.name === 'footnoteReference') {
referencedLabels.add(node.attrs.referenceId)
}
})

const containerPos = offset

const orphans: { pos: number, size: number }[] = []
Expand Down
Loading