feat: Nextcloud 33 compatibility (NC 31–33, PHP 8.2–8.5)#174
Open
Copilot wants to merge 3 commits into
Open
Conversation
… dead code cleanup Agent-Logs-Url: https://github.com/nextcloud/unsplash/sessions/7e0896b2-5c33-4d74-a979-fa2e6d6cda1b Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
…all providers Agent-Logs-Url: https://github.com/nextcloud/unsplash/sessions/7e0896b2-5c33-4d74-a979-fa2e6d6cda1b Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
…roller Agent-Logs-Url: https://github.com/nextcloud/unsplash/sessions/7e0896b2-5c33-4d74-a979-fa2e6d6cda1b Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
skjnldsv
April 23, 2026 15:11
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the app into compliance with Nextcloud 33 requirements: drops PHP 8.1 (removed in NC33), adds PHP 8.5, bumps supported NC range to 31–33, and eliminates all internal
OC\*API usage.Breaking fixes (PHP 8.2+ / NC33)
FILTER_SANITIZE_STRINGremoved — replaced with direct casts inAdminSettingsController; added explicit whitelist validation ingetCustomization()so unknown provider names return HTTP 400 instead of silently falling throughOC\Security\CSP\ContentSecurityPolicy→OCP\AppFramework\Http\ContentSecurityPolicyOC_Defaults→OCP\DefaultsinPersonalSettingsandSettingsServiceuse OC\AppFramework\Http\Request— removed from four provider files where it was imported but never usedHTTP client modernisation
Replaced all raw
curl_*andfile_get_contents()calls with Nextcloud'sIClientService(respects proxy config, SSL settings, and the new NC33 user-agent).IClientServiceis injected into theProviderbase class and propagated throughProviderDefinitions→SettingsService:All concrete providers (
WikimediaCommons,WikimediaCommonsDaily,WallhavenCC) now call$this->getData()instead of directcurl_init().BingWallpaperDailyswitches fromfile_get_contents()to the same.Dead code removal
core.login.showLoginFormroute case removed fromBeforeTemplateRenderedEventListener(NC ≥29 lowercase form is the only one needed)getNextcloudVersion()helper and the> 26/> 19version guards removed — always true on NC 31+hasDashboardtemplate conditional removed; dashboard has been present since NC 20LegacyInitialisationServiceimport removed fromApplication.phpVersion bump
appinfo/info.xml:3.1.0→3.2.0, NC26–32→31–33, PHP8.0–8.4→8.2–8.5