Skip to content

fix(cli): Abort early if file does not exist #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 1 commit into from
May 27, 2025
Merged

fix(cli): Abort early if file does not exist #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/Command/Import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$io = new SymfonyStyle($input, $output);

try {
$path = $input->getArgument('archive');
if (!file_exists($path)) {
Copy link
Copy Markdown
Contributor

@artonge artonge May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with S3 as primary storage?

Copy link
Copy Markdown
Collaborator Author

@come-nc come-nc May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a local zip file that we are importing from.

Copy link
Copy Markdown
Collaborator Author

@come-nc come-nc May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

occ user:import /path/to/my/file.zip

$io->error("File {$path} could not be found");
$io->writeln('aborted.');
return self::FAILURE;
}
$uid = $input->getOption('user');
if (!empty($uid)) {
$user = $this->userManager->get($uid);
Expand All @@ -64,7 +70,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
} else {
$user = null;
}
$path = $input->getArgument('archive');
$io->writeln("Importing from {$path}…");
$importSource = new ImportSource($path);
$this->migrationService->import($importSource, $user, $io);
Expand Down