Skip to content

Commit 5311070

Browse files
committed
fix sso redirect when redirectUrl is null
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
1 parent 7faff3f commit 5311070

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

lib/AppInfo/Application.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,10 @@ private function registerRedirect(IRequest $request, IURLGenerator $urlGenerator
106106
// if the login page's redirect_url GET param is the logout page, just use the base URL instead
107107
$logoutUrl = $urlGenerator->linkToRoute('core.login.logout');
108108
$userOidcLogoutUrl = $urlGenerator->linkToRoute(self::APP_ID . '.login.singleLogoutService');
109-
if (strpos($redirectUrl, $logoutUrl) !== false || strpos($redirectUrl, $userOidcLogoutUrl) !== false) {
109+
if (
110+
$redirectUrl
111+
&& (strpos($redirectUrl, $logoutUrl) !== false || strpos($redirectUrl, $userOidcLogoutUrl) !== false)
112+
) {
110113
$redirectUrl = $urlGenerator->getBaseUrl();
111114
}
112115
$targetUrl = $urlGenerator->linkToRoute(self::APP_ID . '.login.login', [

0 commit comments

Comments
 (0)