add comment about improving when registerRedirect is called

julien-nc · julien-nc · commit 7faff3f42649 · 2024-01-23T16:43:59.000+01:00
Signed-off-by: Julien Veyssier &lt;julien-nc@posteo.net&gt;
diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
@@ -87,6 +87,10 @@ public function boot(IBootContext $context): void {
 	}
 
 	private function registerRedirect(IRequest $request, IURLGenerator $urlGenerator, SettingsService $settings, ProviderMapper $providerMapper): void {
+		// TODO when min supported version is >=28 :
+		// run this in a listener of OCP\AppFramework\Http\Events\BeforeLoginTemplateRenderedEvent
+		// to avoid doing useless stuff on data requests and template requests that are not the login page
+
 		$providers = $this->getCachedProviders($providerMapper);
 		$redirectUrl = $request->getParam('redirect_url');
 

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,10 @@ public function boot(IBootContext $context): void {`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`private function registerRedirect(IRequest $request, IURLGenerator $urlGenerator, SettingsService $settings, ProviderMapper $providerMapper): void {`
	`90`	`+ // TODO when min supported version is >=28 :`
	`91`	`+ // run this in a listener of OCP\AppFramework\Http\Events\BeforeLoginTemplateRenderedEvent`
	`92`	`+ // to avoid doing useless stuff on data requests and template requests that are not the login page`
	`93`	`+`
`90`	`94`	`$providers = $this->getCachedProviders($providerMapper);`
`91`	`95`	`$redirectUrl = $request->getParam('redirect_url');`
`92`	`96`