Skip to content

perf(ldap): Optimize check if LDAP user is deleted#1414

Merged
CarlSchwan merged 1 commit intomainfrom
carl/optimize-ldap-is-deleted
Apr 15, 2026
Merged

perf(ldap): Optimize check if LDAP user is deleted#1414
CarlSchwan merged 1 commit intomainfrom
carl/optimize-ldap-is-deleted

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

Check first if the current user is deleted, before loading all the deleted users and checking if their deletion is still up-to-date.

Allow to abort early for non-deleted users.

isUserMarked is available since NC 28

@CarlSchwan CarlSchwan requested a review from julien-nc April 15, 2026 10:15
@CarlSchwan CarlSchwan self-assigned this Apr 15, 2026
@CarlSchwan CarlSchwan force-pushed the carl/optimize-ldap-is-deleted branch 2 times, most recently from d98410e to 882ca8b Compare April 15, 2026 10:38
Check first if the current user is deleted, before loading all the
deleted users and checking if their deletion is still up-to-date.

Allow to abort early for non-deleted users.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/optimize-ldap-is-deleted branch from 882ca8b to 8423899 Compare April 15, 2026 10:47
Copy link
Copy Markdown
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarlSchwan CarlSchwan merged commit 4128353 into main Apr 15, 2026
51 of 53 checks passed
@CarlSchwan CarlSchwan deleted the carl/optimize-ldap-is-deleted branch April 15, 2026 11:15
@julien-nc julien-nc mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants