Align with backchannel logout OIDC spec#1432
Open
Spitfireap wants to merge 7 commits intonextcloud:mainfrom
Open
Align with backchannel logout OIDC spec#1432Spitfireap wants to merge 7 commits intonextcloud:mainfrom
Spitfireap wants to merge 7 commits intonextcloud:mainfrom
Conversation
da506df to
149ded7
Compare
Author
|
@julien-nc not entirely sure about the change for the error logging. |
julien-nc
requested changes
Apr 29, 2026
302aee6 to
0478e3e
Compare
see nextcloud#1430 Signed-off-by: Spitap <dev@asdrip.fr>
not used since 9b5d6c6 Signed-off-by: Spitap <dev@asdrip.fr>
Admins should be aware that a BCLO attempt failed since it might be a security issue. On the other side we shouldn't spam them if an unknown IdP is attempting a logout Signed-off-by: Spitap <dev@asdrip.fr>
Signed-off-by: Spitap <dev@asdrip.fr>
Signed-off-by: Spitap <dev@asdrip.fr>
0478e3e to
05b982d
Compare
Signed-off-by: Spitap <dev@asdrip.fr>
Signed-off-by: Spitap <dev@asdrip.fr>
Author
|
Added some more alignment with the spec (exp + 1 iss validation step). Was wondering if we should verify that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1430
Current behaviour
Backchannel logout yields a HTTP/400 error when the session is not retrieved.
The spec states that it should be considered as a success and thus should return HTTP/200 :
Furthermore the response seems to be missing the Cache-Control header (spec).
The BC logout validation is also missing exp token validation (not expired) and iss validation (equals to issuer in discovery endpoint) per Backchannel logout token validation spec and ID Token validation spec
Changes
getBackchannelLogoutErrorResponse($throttleMetadata)