Report type error for record type constructor

Signed-off-by: Ben Sherman <bentshermann@gmail.com>

Author: bentsherman

src/main/java/nextflow/script/control/TypeCheckingVisitorEx.java

@@ -57,6 +57,7 @@
 import org.codehaus.groovy.ast.expr.ClassExpression;
 import org.codehaus.groovy.ast.expr.ClosureExpression;
 import org.codehaus.groovy.ast.expr.ConstantExpression;
+import org.codehaus.groovy.ast.expr.ConstructorCallExpression;
 import org.codehaus.groovy.ast.expr.DeclarationExpression;
 import org.codehaus.groovy.ast.expr.ElvisOperatorExpression;
 import org.codehaus.groovy.ast.expr.EmptyExpression;
@@ -841,6 +842,14 @@ private boolean checkTupleCall(MethodCallExpression node) {
         return true;
     }
 
+    @Override
+    public void visitConstructorCallExpression(ConstructorCallExpression node) {
+        var type = node.getType();
+        if( TypesEx.isRecordType(type) )
+            addError("Record type " + TypesEx.getName(type) + " cannot be used as a constructor -- use `record()` instead", node);
+        super.visitConstructorCallExpression(node);
+    }
+
     @Override
     public void visitBinaryExpression(BinaryExpression node) {
         super.visitBinaryExpression(node);

src/test/groovy/nextflow/script/types/TypeCheckingTest.groovy

@@ -1012,7 +1012,24 @@ class TypeCheckingTest extends Specification {
         then:
         TypesEx.getName(type) == 'String'
     }
-    
+
+    def 'should report error for record type constructor' () {
+        expect:
+        check(
+            '''\
+            record Sample {
+                id: String
+                reads: List<Path>
+            }
+
+            workflow {
+                new Sample()
+            }
+            ''',
+            'Record type Sample cannot be used as a constructor -- use `record()` instead'
+        )
+    }
+
     def 'should resolve record sum' () {
         when:
         def exp = parseExpression(