Add missing unit tests for script/config providers

Signed-off-by: Ben Sherman <bentshermann@gmail.com>

Author: bentsherman

src/test/groovy/nextflow/lsp/TestLanguageClient.groovy

@@ -17,7 +17,9 @@
 package nextflow.lsp
 
 import java.util.concurrent.CompletableFuture
+import java.util.concurrent.ConcurrentHashMap
 
+import org.eclipse.lsp4j.Diagnostic
 import org.eclipse.lsp4j.MessageActionItem
 import org.eclipse.lsp4j.MessageParams
 import org.eclipse.lsp4j.PublishDiagnosticsParams
@@ -30,6 +32,8 @@ import org.eclipse.lsp4j.services.LanguageClient
  */
 class TestLanguageClient implements LanguageClient {
 
+    private final Map<String,List<Diagnostic>> diagnostics = new ConcurrentHashMap<>()
+
     @Override
     public void telemetryEvent(Object object) {
     }
@@ -44,11 +48,35 @@ class TestLanguageClient implements LanguageClient {
     }
 
     @Override
-    public void publishDiagnostics(PublishDiagnosticsParams diagnostics) {
+    public void publishDiagnostics(PublishDiagnosticsParams params) {
+        diagnostics.put(params.getUri(), params.getDiagnostics())
     }
 
     @Override
     public void logMessage(MessageParams message) {
         System.err.println(message.getMessage())
     }
+
+    /**
+     * Get the most recently published diagnostics for a given file.
+     *
+     * @param uri
+     */
+    List<Diagnostic> getDiagnostics(String uri) {
+        return diagnostics.getOrDefault(uri, Collections.emptyList())
+    }
+
+    /**
+     * Get the most recently published diagnostics for all files.
+     */
+    Map<String,List<Diagnostic>> getAllDiagnostics() {
+        return diagnostics
+    }
+
+    /**
+     * Forget all captured diagnostics.
+     */
+    void resetDiagnostics() {
+        diagnostics.clear()
+    }
 }

src/test/groovy/nextflow/lsp/TestUtils.groovy

@@ -46,9 +46,19 @@ class TestUtils {
      * Get a language service instance for Nextflow config files.
      */
     static ConfigService getConfigService() {
+        return getConfigService(new TestLanguageClient())
+    }
+
+    /**
+     * Get a language service instance for Nextflow config files, connected to
+     * the given client so that published diagnostics can be inspected.
+     *
+     * @param client
+     */
+    static ConfigService getConfigService(TestLanguageClient client) {
         def service = new ConfigService(workspaceRoot.toUri().toString())
         def configuration = LanguageServerConfiguration.defaults()
-        service.connect(new TestLanguageClient())
+        service.connect(client)
         service.initialize(configuration)
         // skip workspace scan
         open(service, getUri('nextflow.config'), '')
@@ -60,10 +70,20 @@ class TestUtils {
      * Get a language service instance for Nextflow scripts.
      */
     static ScriptService getScriptService() {
+        return getScriptService(new TestLanguageClient())
+    }
+
+    /**
+     * Get a language service instance for Nextflow scripts, connected to the
+     * given client so that published diagnostics can be inspected.
+     *
+     * @param client
+     */
+    static ScriptService getScriptService(TestLanguageClient client) {
         def service = new ScriptService(workspaceRoot.toUri().toString())
         def configuration = LanguageServerConfiguration.defaults()
         def pluginSpecCache = new PluginSpecCache(configuration.pluginRegistryUrl())
-        service.connect(new TestLanguageClient())
+        service.connect(client)
         service.initialize(configuration, pluginSpecCache)
         // skip workspace scan
         open(service, getUri('main.nf'), '')

src/test/groovy/nextflow/lsp/services/config/ConfigCompletionTest.groovy

@@ -0,0 +1,117 @@
+/*
+ * Copyright 2024-2025, Seqera Labs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package nextflow.lsp.services.config
+
+import org.eclipse.lsp4j.CompletionItem
+import org.eclipse.lsp4j.CompletionItemKind
+import org.eclipse.lsp4j.CompletionParams
+import org.eclipse.lsp4j.Position
+import org.eclipse.lsp4j.TextDocumentIdentifier
+import spock.lang.Specification
+
+import static nextflow.lsp.TestUtils.*
+
+/**
+ *
+ * @author Ben Sherman <bentshermann@gmail.com>
+ */
+class ConfigCompletionTest extends Specification {
+
+    // NOTE: completion() runs its own update internally, so (unlike hover or
+    // definition) the file must NOT be flushed with updateNow() beforehand.
+
+    def either(ConfigService service, String uri, Position position, int maxItems = 100) {
+        return service.completion(new CompletionParams(new TextDocumentIdentifier(uri), position), maxItems, false)
+    }
+
+    List<CompletionItem> getCompletions(ConfigService service, String uri, Position position, int maxItems = 100) {
+        def result = either(service, uri, position, maxItems)
+        return result.isLeft() ? result.getLeft() : result.getRight().getItems()
+    }
+
+    def 'should provide top-level completions for a partial scope name' () {
+        given:
+        def service = getConfigService()
+        def uri = getUri('nextflow.config')
+
+        when:
+        open(service, uri, 'wor\n')
+        def completions = getCompletions(service, uri, new Position(0, 3))
+        def byLabel = completions.collectEntries { [(it.getLabel()): it] }
+        then: 'a scope is offered both as a bare name and as a block snippet'
+        byLabel['process']?.getKind() == CompletionItemKind.Property
+        byLabel['process {']?.getKind() == CompletionItemKind.Property
+        and: 'a top-level option carries its type in the detail'
+        byLabel['workDir']?.getDetail()?.startsWith('workDir:')
+    }
+
+    def 'should provide option completions for a config scope' () {
+        given:
+        def service = getConfigService()
+        def uri = getUri('nextflow.config')
+
+        when:
+        open(service, uri, 'process.\n')
+        def completions = getCompletions(service, uri, new Position(0, 8))
+        def cpus = completions.find { it.getLabel() == 'cpus' }
+        then:
+        cpus != null
+        cpus.getKind() == CompletionItemKind.Property
+        cpus.getDetail() == 'cpus: Integer'
+    }
+
+    def 'should provide option completions inside a profile, ignoring the profile scope' () {
+        given:
+        def service = getConfigService()
+        def uri = getUri('nextflow.config')
+
+        when:
+        open(service, uri, '''\
+            profiles {
+                standard {
+                    process.
+                }
+            }
+            ''')
+        def completions = getCompletions(service, uri, new Position(2, 16))
+        then: 'the "profiles.<name>" prefix is stripped, so process options are offered'
+        completions.find { it.getLabel() == 'cpus' }?.getDetail() == 'cpus: Integer'
+    }
+
+    def 'should mark the completion list incomplete when items exceed maxItems' () {
+        given:
+        def service = getConfigService()
+        def uri = getUri('nextflow.config')
+
+        when:
+        open(service, uri, 'process.\n')
+        def result = either(service, uri, new Position(0, 8), 1)
+        then:
+        result.isRight()
+        result.getRight().isIncomplete()
+        result.getRight().getItems().size() == 1
+    }
+
+    def 'should return no completions for a file that is not open' () {
+        given:
+        def service = getConfigService()
+
+        expect:
+        getCompletions(service, getUri('other.config'), new Position(0, 0)).isEmpty()
+    }
+
+}

src/test/groovy/nextflow/lsp/services/config/ConfigLinkTest.groovy

@@ -0,0 +1,81 @@
+/*
+ * Copyright 2024-2025, Seqera Labs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package nextflow.lsp.services.config
+
+import org.eclipse.lsp4j.DocumentLinkParams
+import org.eclipse.lsp4j.TextDocumentIdentifier
+import spock.lang.Specification
+
+import static nextflow.lsp.TestUtils.*
+
+/**
+ *
+ * @author Ben Sherman <bentshermann@gmail.com>
+ */
+class ConfigLinkTest extends Specification {
+
+    List getLinks(ConfigService service, String uri) {
+        return service.documentLink(new DocumentLinkParams(new TextDocumentIdentifier(uri)))
+    }
+
+    def 'should resolve a relative config include against the parent directory' () {
+        given:
+        def service = getConfigService()
+        def uri = getUri('nextflow.config')
+
+        when:
+        open(service, uri, '''\
+            includeConfig 'conf/base.config'
+            ''')
+        service.updateNow()
+        def links = getLinks(service, uri)
+        then:
+        links.size() == 1
+        links[0].getTarget() == getUri('conf/base.config')
+    }
+
+    def 'should pass through an absolute include URI unchanged' () {
+        given:
+        def service = getConfigService()
+        def uri = getUri('nextflow.config')
+
+        when:
+        open(service, uri, '''\
+            includeConfig 'https://example.com/shared.config'
+            ''')
+        service.updateNow()
+        def links = getLinks(service, uri)
+        then:
+        links.size() == 1
+        links[0].getTarget() == 'https://example.com/shared.config'
+    }
+
+    def 'should produce no links for a config without includes' () {
+        given:
+        def service = getConfigService()
+        def uri = getUri('nextflow.config')
+
+        when:
+        open(service, uri, '''\
+            process.cpus = 2
+            ''')
+        service.updateNow()
+        then:
+        getLinks(service, uri).isEmpty()
+    }
+
+}