Fix cached task after abort

[jorgee]

Close #6884
Alternative for #6882
This pull request enhances task retry logic in Nextflow by improving how task failures and aborts are tracked and incorporated into cache key calculation. The changes ensure that both failure and abort counts are considered, making task resumption and retry behavior more robust and predictable.

Task retry and cache logic improvements:

• The hash used for determining task cache keys now includes both failCount and a new abortedCount to ensure that retries after aborts or failures use a distinct hash.
• When a cached entry is found with a status of FAILED or ABORTED, the corresponding counters (failCount or abortedCount) on the TaskRun object are incremented, ensuring accurate retry attempts and cache key updates.

Task state tracking enhancements:

• Added a new abortedCount field to the TaskRun class to track the number of times a task execution has been aborted.
• Introduced isAborted() and isFailed() helper methods to the TraceRecord class for clearer and more maintainable status checks.

TODO:

• Check attempts
• Add test to reproduce failure and check fix

[netlify]

✅ Deploy Preview for nextflow-docs-staging canceled.

Name	Link
🔨 Latest commit	9e0f93f
🔍 Latest deploy log	https://app.netlify.com/projects/nextflow-docs-staging/deploys/69e61e983b4ab50008993fd9

[vagkaratzas]

Any update on this one? :'D

[jorgee]

This PR is ready, just this minor comment not related to the issue.

[bentsherman]

@jorgee does this test need to be updated since I removed the extra logic? it is failing for me locally

[jorgee]

Yes, now the third execution also retries and execution will take more time. Updating it.

[jorgee]

It seems there was an inconsistency with failed counts and failed counts. Removing the code, the number of attempts was not increased but failedCounts yes, and it is also used for retries.

I have renamed the abortedCount to previousFailOrAbortedCount. It stores the aborted and failed cached execution. This is just used for increasing the tries

[bentsherman]

Okay, I think I understand all the changes. The only problem now is that this e2e test continues to fail locally

[jorgee]

Is it possible to get the log of your e2e test? I would like to know why is it failing in your case.

[pditommaso]

Please add unit tests to capture this behaviour

[jorgee]

Please add unit tests to capture this behaviour

There was a validation tests checking the full fuctionality. I have added unit tests in the last commit.

[bentsherman]

CORRECTION: Closing in favor of #7194