ADR: Process error: section#7233
Open
bentsherman wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
adamrtalbot
reviewed
Jun 24, 2026
Comment on lines
+45
to
+47
| ## Solution | ||
|
|
||
| Introduce an **`error:` section** for typed processes, with the same syntax as the `output:` section. A domain error is detected structurally -- **a task that succeeds (exit 0) but does not fulfill its declared `output:`** -- and is emitted as an error value instead of triggering the error strategy. |
Collaborator
There was a problem hiding this comment.
I'm not sure this is sufficient for separating the domain vs infrastructure errors.
See https://nfcore.slack.com/archives/C043FMKUNLB/p1782301366504629 for a relevant discussion.
Member
Author
There was a problem hiding this comment.
Left some comments there. That discussion seems to be more about distinguishing between different kinds of execution errors
bentsherman
commented
Jun 27, 2026
Comment on lines
+80
to
+83
| aligner ${reads} ${index} > aligned.bam 2> aligner.log || { | ||
| rm -f aligned.bam | ||
| exit 0 | ||
| } |
Member
Author
There was a problem hiding this comment.
TODO: wrap exit code wrangling in an error() Bash function for re-use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an ADR for the proposed process
error:section, which provides a way to capture and emit domain errors, allowing users to handle them with workflow logic rather than the error strategy.