fix(cron): always reset session before cron runs — stateless flag inverted#1032
Open
kamushadenes wants to merge 1 commit into
Open
fix(cron): always reset session before cron runs — stateless flag inverted#1032kamushadenes wants to merge 1 commit into
kamushadenes wants to merge 1 commit into
Conversation
The stateless flag was supposed to prevent session history accumulation, but the reset logic was inverted: non-stateless jobs got reset while stateless jobs were skipped. Since the agent loop always persists messages to the session key regardless of the stateless flag, stateless cron jobs accumulated unbounded history across runs. Fix by unconditionally resetting the session before every cron execution. This is consistent with nextlevelbuilder#294 (which added the reset for non-stateless jobs) and ensures stateless jobs actually start fresh each run. Fixes nextlevelbuilder#1029-related session accumulation observed in production. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kamushadenes
added a commit
to kamushadenes/goclaw
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cron jobs with
stateless=trueaccumulate unbounded session history because the reset logic is inverted.Current code (
cmd/gateway_cron.go:92):This resets non-stateless jobs but skips stateless ones. The agent loop always persists messages to the session key regardless of the stateless flag, so stateless cron sessions grow indefinitely.
Observed in production: A stateless cron job accumulated 230KB of messages over ~10 runs. The model saw stale context from previous runs, causing it to skip data collection ("already done").
Fix: Remove the condition — always reset before cron execution. This is consistent with the intent of #294 (which added the reset to prevent error accumulation) and ensures stateless jobs actually start fresh.
Test plan