feat(acp): Gemini ACP protocol standardization + provider hot-reload + Gemini embedding#1067
Closed
codebit0 wants to merge 1 commit intonextlevelbuilder:devfrom
Closed
feat(acp): Gemini ACP protocol standardization + provider hot-reload + Gemini embedding#1067codebit0 wants to merge 1 commit intonextlevelbuilder:devfrom
codebit0 wants to merge 1 commit intonextlevelbuilder:devfrom
Conversation
- ACP 프로토콜 핸들링 표준화 (process/session/tool_bridge/types)
- ACPSettings 통합 설정 구조체 — config.json/DB JSONB 양쪽 경로에서 공유
- ACP MCP 브리지 설정(acpMCPData) 패키지 변수로 공급, 핫리로드 시 갱신
- DB 변경 시 ACP provider 자동 재등록 (gateway 재시작 불필요)
- providers/{id}/verify 엔드포인트: model 필수 + 가용 모델 목록 응답
- Gemini native 임베딩 provider (memory.NewGeminiEmbeddingProvider) 추가
- buildEmbeddingProvider에 GeminiNative 분기 추가
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
9 tasks
Contributor
Author
|
Superseded by #1069 (full integrated branch with ko i18n + ops hardening + ACP). Closing this narrower PR to consolidate review on a single branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup PR for ACP (Agent Client Protocol) provider work. Addresses protocol-compatibility issues and operational improvements discovered while integrating the Gemini CLI as an ACP-compatible agent.
Changes
internal/providers/acp/{process,session,tool_bridge,types}.goand testssession/request_permissionfor Gemini CLI 0.38.xACPSettingsconfig struct — both registration paths (config.jsonproviders.acpand DBllm_providers.settingsJSONB) share the same option set (name/binary/args/model/perm_mode/idle_ttl/session_ttl/prompt_timeout/work_dir/include_directories/mcp_data)SetProviderReloadFncallback +acpMCPDatapackage var refresh)POST /v1/providers/{id}/verifymodelis now required (ping mode removed){success, models[]}--modelflag removed; verification prints the list of available modelsmemory.NewGeminiEmbeddingProviderand aProviderGeminiNativebranch inbuildEmbeddingProviderOut of scope (split into follow-up PRs)
BuiltinToolStore-based tool selection refactor (internal/mcp/bridge_server.go,internal/gateway/server.goBuiltinTools wire)Test plan
go build ./...(PG) passesgo build -tags sqliteonly ./...(Desktop/SQLite) passesgo vet ./...passesgo test -race -tags integration ./tests/integration/) — to be verified in reviewer environmentgoclaw providers verify <id>prints the available model list