Fix/pipeline compaction pending loss#1182
Open
ollielin wants to merge 3 commits into
Open
Conversation
release: promote v3.12.0 official
release: promote v3.12.0
When PruneStage or ThinkStage triggers mid-loop compaction, ReplaceHistory() clears the pending buffer. If the current iteration's assistant(tool_calls) message is in pending, it gets discarded. The next iteration then sends tool-result messages without a preceding tool_calls message, causing DeepSeek/OpenAI to reject the request with HTTP 400: Messages with role 'tool' must be a response to a preceding message with 'tool_calls' Fix: save pending before ReplaceHistory and restore it after. Reproduction: - Agent with 64K context window - 4-5 consecutive tool calls (e.g. read_file) in one session - Token count exceeds soft budget during ToolStage - PruneStage compaction clears pending including assistant(tool_calls) - Next iteration fails with HTTP 400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type
main)Target Branch
Checklist
go build ./...passesgo build -tags sqliteonly ./...passes (if Go changes)go vet ./...passesgo test -race ./...cd ui/web && pnpm build(if UI changes)$1, $2(no string concat)internal/upgrade/version.go(if new migration)Test Plan