fix(ci): replace broken conda workflow with pip + CLI build validation#325
Open
alfredo-petri wants to merge 1 commit into
Open
fix(ci): replace broken conda workflow with pip + CLI build validation#325alfredo-petri wants to merge 1 commit into
alfredo-petri wants to merge 1 commit into
Conversation
The previous workflow referenced environment.yml which does not exist in the repository, causing every push to fail. It also had no validation for the CLI package. Changes: - Remove conda dependency; use pip to install flake8 directly - Lint only src/ui-ux-pro-max/scripts/ (the actual Python source) - Add a smoke test: run search.py to confirm the script is importable - Add cli-build job: bun install + build + npm pack --dry-run to catch packaging regressions before they reach npm Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Summary: I’m blocking this PR from the cron-safe maintainer lane because it is now stale against current main and reintroduces an obsolete CI file. Decision: blocked / needs rebase or close Evidence:
Next step: please rebase on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/workflows/python-package-conda.ymlreferencesenvironment.yml(line 23) which does not exist in the repository. Every push triggers a failing CI job.Additionally, there was no CI validation for the CLI package, so regressions in the TypeScript build or npm packaging could go undetected until a user tries to install.
Fix
Python job:
pip install flake8directlysrc/ui-ux-pro-max/scripts/(the actual source)search.pywith a real query to confirm the script is importable and functionalNew
cli-buildjob:oven-sh/setup-bun@v2(official Bun action)bun install+bun run build+npm pack --dry-runto catch packaging regressions🤖 Generated with Claude Code