feat(react): add React 19 guidelines to stack data#344
Conversation
Add 6 new rows covering React 19 APIs:
- useActionState for form submissions with built-in pending state
- useFormStatus for child components to read submit state without prop drilling
- use() hook for reading Promises and Context mid-render
- ref as plain prop (forwardRef deprecated)
- useOptimistic for instant UI feedback before async resolves
- <form action={fn}> for progressive form enhancement with Server Actions
Sync cli/assets to match src.
mrgoonie
left a comment
There was a problem hiding this comment.
Summary: This is a narrow stack-data update adding React 19 guidance to both the canonical source CSV and bundled CLI asset copy.
Risk level: Low
Mandatory gates:
- Duplicate/prior implementation: clear — no overlapping React 19 issue/PR found in the current queue search.
- Project standards: passed — source and CLI asset paths are updated together, matching the repo pattern for stack CSV data.
- Strategic necessity: clear value — React 19 APIs are current guidance that improves generated React advice without changing runtime code.
- CI/checks: failing external claude-review from 2026-06-09; no repo test failure evidence was available from the check log.
Findings:
- Critical: none.
- Important: none.
- Suggestion: future data-only PRs should preserve line endings consistently between source and generated asset copies to keep diffs smaller.
Verdict: APPROVE
I am not merging this in the same run because GitHub reports mergeStateStatus=UNSTABLE and the visible status check is failed.
|
Cron maintainer recheck: PR #344 remains approved and is a good content addition (6 React 19 guidelines with proper src/cli/assets sync), but it still has mergeStateStatus=DIRTY and a failed claude-review CI check from 2026-06-09. To move this forward:
Once mergeStateStatus is clean and CI passes (or the failed check is stale/dismissed), this can be merged. Posted by github-maintain cron at 2026-06-26T08:00:00Z |
|
Cron maintainer check (2026-06-26): This PR is approved ✅ but currently has merge conflicts that block merging. Action needed: Please rebase or merge The React 19 guideline additions (useActionState, useFormStatus, use(), ref as prop, useOptimistic, form actions) are approved and ready to land — just needs a clean merge state. Posted by github-maintain cron at 2026-06-26T11:22:58Z |
clark-cant
left a comment
There was a problem hiding this comment.
github-maintain review
Summary: Adds 6 React 19 guidelines (useActionState, useFormStatus, use() hook, ref-as-prop, useOptimistic, form action) to the React stack CSV, with cli/assets sync.
Risk level: Low — data-only change, no code logic.
Mandatory gates:
- Duplicate/prior implementation: clear — no prior React 19 data exists in the repo
- Project standards: clear — follows existing CSV format and row numbering convention
- Strategic necessity: clear value — keeps the skill's React stack data current with the latest stable React release
Findings: No issues. The 6 new rows (54-59) are well-structured, properly categorized under a new "React 19" category, and include appropriate severity levels and docs URLs. The cli/assets sync matches the src/ source of truth.
Note: Branch is behind main (mergeStateStatus: DIRTY). Author needs to rebase before merge.
Verdict: Approve ✅
Posted by github-maintain cron at 2026-07-02T17:00:00Z
|
Please rebase against current |
Add 6 new rows covering React 19 APIs:
Sync cli/assets to match src.