Skip to content

feat(react): add React 19 guidelines to stack data#344

Open
Ray0907 wants to merge 1 commit into
nextlevelbuilder:mainfrom
Ray0907:feat/react-19-stack
Open

feat(react): add React 19 guidelines to stack data#344
Ray0907 wants to merge 1 commit into
nextlevelbuilder:mainfrom
Ray0907:feat/react-19-stack

Conversation

@Ray0907

@Ray0907 Ray0907 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Add 6 new rows covering React 19 APIs:

  • useActionState for form submissions with built-in pending state
  • useFormStatus for child components to read submit state without prop drilling
  • use() hook for reading Promises and Context mid-render
  • ref as plain prop (forwardRef deprecated)
  • useOptimistic for instant UI feedback before async resolves
  • for progressive form enhancement with Server Actions

Sync cli/assets to match src.

Add 6 new rows covering React 19 APIs:
- useActionState for form submissions with built-in pending state
- useFormStatus for child components to read submit state without prop drilling
- use() hook for reading Promises and Context mid-render
- ref as plain prop (forwardRef deprecated)
- useOptimistic for instant UI feedback before async resolves
- <form action={fn}> for progressive form enhancement with Server Actions

Sync cli/assets to match src.

@mrgoonie mrgoonie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This is a narrow stack-data update adding React 19 guidance to both the canonical source CSV and bundled CLI asset copy.

Risk level: Low

Mandatory gates:

  • Duplicate/prior implementation: clear — no overlapping React 19 issue/PR found in the current queue search.
  • Project standards: passed — source and CLI asset paths are updated together, matching the repo pattern for stack CSV data.
  • Strategic necessity: clear value — React 19 APIs are current guidance that improves generated React advice without changing runtime code.
  • CI/checks: failing external claude-review from 2026-06-09; no repo test failure evidence was available from the check log.

Findings:

  • Critical: none.
  • Important: none.
  • Suggestion: future data-only PRs should preserve line endings consistently between source and generated asset copies to keep diffs smaller.

Verdict: APPROVE

I am not merging this in the same run because GitHub reports mergeStateStatus=UNSTABLE and the visible status check is failed.

@mrgoonie mrgoonie added agent:github-maintain Processed by github-maintain automation pr:reviewed PR reviewed by maintain workflow pr:approved-by-maintain Approved by github-maintain workflow labels Jun 20, 2026
@clark-cant

Copy link
Copy Markdown
Contributor

Cron maintainer recheck: PR #344 remains approved and is a good content addition (6 React 19 guidelines with proper src/cli/assets sync), but it still has mergeStateStatus=DIRTY and a failed claude-review CI check from 2026-06-09.

To move this forward:

  1. Rebase onto current main to resolve merge conflicts
  2. Push the updated branch so CI re-runs

Once mergeStateStatus is clean and CI passes (or the failed check is stale/dismissed), this can be merged.

Posted by github-maintain cron at 2026-06-26T08:00:00Z

@clark-cant

Copy link
Copy Markdown
Contributor

Cron maintainer check (2026-06-26): This PR is approved ✅ but currently has merge conflicts that block merging.

Action needed: Please rebase or merge main into your branch feat/react-19-stack to resolve the conflicts. Once the mergeable status flips to MERGEABLE, the cron maintainer lane will attempt an automatic merge on the next pass.

The React 19 guideline additions (useActionState, useFormStatus, use(), ref as prop, useOptimistic, form actions) are approved and ready to land — just needs a clean merge state.

Posted by github-maintain cron at 2026-06-26T11:22:58Z

@clark-cant clark-cant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-maintain review

Summary: Adds 6 React 19 guidelines (useActionState, useFormStatus, use() hook, ref-as-prop, useOptimistic, form action) to the React stack CSV, with cli/assets sync.

Risk level: Low — data-only change, no code logic.

Mandatory gates:

  • Duplicate/prior implementation: clear — no prior React 19 data exists in the repo
  • Project standards: clear — follows existing CSV format and row numbering convention
  • Strategic necessity: clear value — keeps the skill's React stack data current with the latest stable React release

Findings: No issues. The 6 new rows (54-59) are well-structured, properly categorized under a new "React 19" category, and include appropriate severity levels and docs URLs. The cli/assets sync matches the src/ source of truth.

Note: Branch is behind main (mergeStateStatus: DIRTY). Author needs to rebase before merge.

Verdict: Approve

Posted by github-maintain cron at 2026-07-02T17:00:00Z

@clark-cant clark-cant added maintain:blocked Blocked by external condition or maintainer action pr:blocked-conflict PR blocked by merge conflicts labels Jul 3, 2026
@clark-cant

Copy link
Copy Markdown
Contributor

⚠️ Merge conflict detected — This PR was previously approved but now has merge conflicts with main (mergeStateStatus=DIRTY). The branch needs to be rebased or updated before merge can proceed.

Please rebase against current main and resolve any conflicts. After pushing the updated branch, the PR will be re-evaluated for merge readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:github-maintain Processed by github-maintain automation maintain:blocked Blocked by external condition or maintainer action pr:approved-by-maintain Approved by github-maintain workflow pr:blocked-conflict PR blocked by merge conflicts pr:reviewed PR reviewed by maintain workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants