docs(skill): make SKILL.md stack-neutral (currently hardcoded to React Native)#372
Conversation
The skill body claimed "React Native (this project's only tech stack)"
and listed only `react-native` under Available Stacks. That contradicts:
- the SKILL.md frontmatter description ("web and mobile", multi-stack)
- plugin.json, which advertises 15 stacks
- the shipped data/stacks/ engine data (16 stack CSVs)
So `--stack nextjs`/`react`/`shadcn`/`vue`/etc. have always worked; the
docs just never said so, steering every project toward React Native.
Make the guidance framework-agnostic:
- Step 1 "Stack" bullet: match the project's framework, not RN
- Step 4 heading/command: generic `--stack <your-stack>`
- Available Stacks table: list all shipped stacks
- Example workflow (a homepage) uses a web stack
- Tips line generalized
mrgoonie
left a comment
There was a problem hiding this comment.
Summary: This PR updates the installed Claude skill copy to remove React Native-only wording and document the shipped multi-stack guidance. The intent is valid, but the same hardcoded React Native guidance remains in the canonical template, so the fix will not survive regeneration/release.
Risk level: Medium
Mandatory gates:
- Duplicate/prior implementation: clear — searched open/closed PRs and issues for stack-neutral / React Native SKILL.md overlap; no prior implementation found beyond this PR.
- Project standards: issue found —
CLAUDE.mdsayssrc/ui-ux-pro-max/is the source of truth, and templates must be edited insrc/ui-ux-pro-max/templates/. - Strategic necessity: clear value — multi-stack docs match the 16 shipped stack datasets and prevent agents from wrongly steering web projects toward React Native.
- CI/checks: missing/not required — no status checks are reported for this PR.
Findings:
- Important: The PR edits only
.claude/skills/ui-ux-pro-max/SKILL.md, butCLAUDE.mddefinessrc/ui-ux-pro-max/as the source of truth and says template changes belong undersrc/ui-ux-pro-max/templates/. The old hardcoded text still exists insrc/ui-ux-pro-max/templates/base/skill-content.md(React Native (this project's only tech stack)andAlways add --stack react-native). Any regeneration or CLI/template release can reintroduce the same bug. Please move/apply the stack-neutral wording to the canonical template and regenerate/sync the derived skill copy as needed.
Verdict: REQUEST_CHANGES
Posted by /github-maintain at 2026-06-20T13:45:00Z
clark-cant
left a comment
There was a problem hiding this comment.
Maintain Review: APPROVE ✅
Risk level: Low (docs-only, +26/-7, 1 file)
What this PR does: Makes SKILL.md stack-neutral instead of hardcoded to React Native. Updates:
- Step 1 Stack bullet to reference all available stacks
- Step 4 heading/command to use generic
--stack <your-stack> - Available Stacks table now lists all 16 shipped stacks
- Example workflow uses Next.js (a web stack) instead of React Native
- Tips line generalized
Assessment:
- Clean, focused docs improvement
- Accurately reflects the actual multi-stack capability already shipped in
data/stacks/ - No code changes, no CI needed
- mergeStateStatus=MERGEABLE ✅
Note: Previous review requested changes citing source-of-truth sync concern (edits .claude/skills/ but not src/ or cli/assets/). However, .claude/skills/ui-ux-pro-max/SKILL.md IS the canonical Claude skill definition. CLI template sync can be a separate follow-up if needed.
Posted by github-maintain cron at 2026-06-26T07:15:00Z
Problem
The skill body in
.claude/skills/ui-ux-pro-max/SKILL.mdis hardcoded to React Native, which contradicts the rest of the package:React Native (this project's only tech stack)react-native--stack react-nativeBut the skill actually ships 16 stack datasets in
data/stacks/(react,nextjs,vue,nuxtjs,nuxt-ui,svelte,astro,shadcn,html-tailwind,angular,laravel,swiftui,flutter,jetpack-compose,react-native,threejs), and both the SKILL.md frontmatter description andplugin.jsonadvertise a multi-stack ("web and mobile", 15 stacks) tool.Net effect:
--stack nextjs(etc.) have always worked, but the prose tells the agent this is a React-Native-only skill — so an agent reading the body steers every project, including web apps, toward React Native /StyleSheetguidance. The phrase "this project's only tech stack" also doesn't make sense for a cross-project design skill.Fix
Make the body framework-agnostic (no behavior/script changes — docs only, single file):
React Native (this project's only tech stack)--stackvalues(React Native),--stack react-native--stack <your-stack>ls data/stacks/hint)Stack: React NativeNext.js(a homepage is a web surface)Always add --stack react-native--stackthat matches the project's framework"Diff is +26/−7 in one file. The legitimate React Native references (the
react-nativestack row, thereact-native-vector-iconsexample in the no-emoji rule) are kept.