Skip to content

Commit 5fb9115

Browse files
Merge pull request nextcloud#12303 from nextcloud/refactor/use-work-manager-for-upload
Use Only Work Manager For File Upload
2 parents c612d7a + f1bd5f1 commit 5fb9115

9 files changed

Lines changed: 51 additions & 193 deletions

File tree

app/src/androidTest/java/com/owncloud/android/files/services/FileUploaderIT.kt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,10 @@ abstract class FileUploaderIT : AbstractOnServerIT() {
139139
val file = getDummyFile("chunkedFile.txt")
140140

141141
FileUploader.uploadNewFile(
142-
targetContext,
143142
user,
144143
file.absolutePath,
145144
"/testFile.txt",
146145
FileUploader.LOCAL_BEHAVIOUR_COPY,
147-
null,
148146
true,
149147
UploadFileOperation.CREATED_BY_USER,
150148
false,
@@ -258,12 +256,10 @@ abstract class FileUploaderIT : AbstractOnServerIT() {
258256
val file = getDummyFile("nonEmpty.txt")
259257

260258
FileUploader.uploadNewFile(
261-
targetContext,
262259
user,
263260
file.absolutePath,
264261
"/testFile.txt",
265262
FileUploader.LOCAL_BEHAVIOUR_COPY,
266-
null,
267263
true,
268264
UploadFileOperation.CREATED_BY_USER,
269265
false,
@@ -369,12 +365,10 @@ abstract class FileUploaderIT : AbstractOnServerIT() {
369365
val file = getDummyFile("chunkedFile.txt")
370366

371367
FileUploader.uploadNewFile(
372-
targetContext,
373368
user,
374369
file.absolutePath,
375370
"/testFile.txt",
376371
FileUploader.LOCAL_BEHAVIOUR_COPY,
377-
null,
378372
true,
379373
UploadFileOperation.CREATED_BY_USER,
380374
false,
@@ -476,12 +470,10 @@ abstract class FileUploaderIT : AbstractOnServerIT() {
476470
val file = getDummyFile("chunkedFile.txt")
477471

478472
FileUploader.uploadNewFile(
479-
targetContext,
480473
user,
481474
file.absolutePath,
482475
"/testFile.txt",
483476
FileUploader.LOCAL_BEHAVIOUR_COPY,
484-
null,
485477
true,
486478
UploadFileOperation.CREATED_BY_USER,
487479
false,

app/src/main/java/com/nextcloud/client/documentscan/DocumentScanViewModel.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import com.owncloud.android.files.services.FileUploader
3636
import com.owncloud.android.files.services.NameCollisionPolicy
3737
import com.owncloud.android.operations.UploadFileOperation
3838
import com.owncloud.android.ui.helpers.FileOperationsHelper
39-
import com.owncloud.android.utils.MimeType
4039
import kotlinx.coroutines.CoroutineDispatcher
4140
import kotlinx.coroutines.Dispatchers
4241
import kotlinx.coroutines.launch
@@ -184,16 +183,10 @@ class DocumentScanViewModel @Inject constructor(
184183
uploadFolder + OCFile.PATH_SEPARATOR + File(it).name
185184
}.toTypedArray()
186185

187-
val mimetypes = pageList.map {
188-
MimeType.JPEG
189-
}.toTypedArray()
190-
191186
FileUploader.uploadNewFile(
192-
getApplication(),
193187
currentAccountProvider.user,
194188
pageList.toTypedArray(),
195189
uploadPaths,
196-
mimetypes,
197190
FileUploader.LOCAL_BEHAVIOUR_DELETE,
198191
true,
199192
UploadFileOperation.CREATED_BY_USER,

app/src/main/java/com/nextcloud/client/documentscan/GeneratePdfFromImagesWork.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ import com.owncloud.android.files.services.FileUploader
3939
import com.owncloud.android.files.services.NameCollisionPolicy
4040
import com.owncloud.android.operations.UploadFileOperation
4141
import com.owncloud.android.ui.notifications.NotificationUtils
42-
import com.owncloud.android.utils.MimeType
4342
import com.owncloud.android.utils.theme.ViewThemeUtils
4443
import java.io.File
4544
import java.security.SecureRandom
@@ -124,12 +123,10 @@ class GeneratePdfFromImagesWork(
124123
val uploadPath = uploadFolder + OCFile.PATH_SEPARATOR + File(pdfPath).name
125124

126125
FileUploader.uploadNewFile(
127-
appContext,
128126
user,
129127
pdfPath,
130128
uploadPath,
131129
FileUploader.LOCAL_BEHAVIOUR_DELETE, // MIME type will be detected from file name
132-
MimeType.PDF,
133130
true,
134131
UploadFileOperation.CREATED_BY_USER,
135132
false,

app/src/main/java/com/nextcloud/client/jobs/FilesSyncWork.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ class FilesSyncWork(
162162
}
163163
val localPaths = pathsAndMimes.map { it.first }.toTypedArray()
164164
val remotePaths = pathsAndMimes.map { it.second }.toTypedArray()
165-
val mimetypes = pathsAndMimes.map { it.third }.toTypedArray()
166165

167166
if (lightVersion) {
168167
needsCharging = resources.getBoolean(R.bool.syncedFolder_light_on_charging)
@@ -177,12 +176,11 @@ class FilesSyncWork(
177176
needsWifi = syncedFolder.isWifiOnly
178177
uploadAction = syncedFolder.uploadAction
179178
}
179+
180180
FileUploader.uploadNewFile(
181-
context,
182181
user,
183182
localPaths,
184183
remotePaths,
185-
mimetypes,
186184
uploadAction!!,
187185
true, // create parent folder if not existent
188186
UploadFileOperation.CREATED_AS_INSTANT_PICTURE,

0 commit comments

Comments
 (0)