Skip to content

Commit 693314a

Browse files
Merge pull request nextcloud#13746 from nextcloud/check-npe-file-detail-binding
Fix Crashes When Opening File Details from Media and Other Tabs
2 parents b9ffda4 + 09033d1 commit 693314a

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,12 @@ public void onTabReselected(TabLayout.Tab tab) {
351351
}
352352
});
353353

354-
binding.tabLayout.post(() -> {
355-
TabLayout.Tab tab1 = binding.tabLayout.getTabAt(activeTab);
356-
if (tab1 == null) return;
357-
tab1.select();
358-
});
354+
// FIXME file detail not opening from Media tab
355+
if (binding != null) {
356+
TabLayout.Tab tab = binding.tabLayout.getTabAt(activeTab);
357+
if (tab == null) return;
358+
binding.tabLayout.selectTab(tab);
359+
}
359360
}
360361

361362
@Override
@@ -580,8 +581,9 @@ public void updateFileDetails(boolean transferring, boolean refresh) {
580581
}
581582

582583
setupViewPager();
583-
584-
getView().invalidate();
584+
if (getView() != null) {
585+
getView().invalidate();
586+
}
585587
}
586588

587589
private void setFileModificationTimestamp(OCFile file, boolean showDetailedTimestamp) {

0 commit comments

Comments
 (0)