Merge branch 'master' into nmc/1933-Collabora_customisation

Author: harshada-15-tsys

.github/workflows/xcode.yml

@@ -19,6 +19,7 @@ env:
   PROJECT: Nextcloud.xcodeproj
   DESTINATION: platform=iOS Simulator,name=iPhone 16,OS=18.5
   SCHEME: Nextcloud
+  XCODE_VERSION: '26.0.1'
   SERVER_BRANCH: stable30
   PHP_VERSION: 8.3
 
@@ -37,7 +38,7 @@ jobs:
     - name: Setup Xcode
       uses: maxim-lobanov/setup-xcode@60606e260d2fc5762a71e64e74b2174e8ea3c8bd # v1.6.0
       with:
-        xcode-version: '26.0.1'
+        xcode-version: ${{ env.XCODE_VERSION }}
 
     - name: Run Xcode Build
       run: |
@@ -60,13 +61,16 @@ jobs:
     runs-on: macos-15
     needs: [build]
 
-    # Temporarily, project has no effective tests except UI tests which are unfeasible on virtualized GitHub runners (see #3291)
-    # Previously: github.event.pull_request.draft == false
-    if: false
-
+    if: github.event.pull_request.draft == false
+    
     steps:
     - uses: actions/checkout@v4
 
+    - name: Setup Xcode
+      uses: maxim-lobanov/setup-xcode@60606e260d2fc5762a71e64e74b2174e8ea3c8bd # v1.6.0
+      with:
+        xcode-version: ${{ env.XCODE_VERSION }}
+
     - name: Prepare PHP ${{ env.PHP_VERSION }}
       uses: shivammathur/setup-php@v2
       with:

AGENTS.md

@@ -0,0 +1,76 @@
+<!--
+  - SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+  - SPDX-License-Identifier: GPL-2.0-or-later
+-->
+
+# AGENTS.md
+
+You are an experienced engineer specialized in Swift and familiar with the platform-specific details of iOS.
+
+## Your Role
+
+- You implement features and fix bugs.
+- Your documentation and explanations are written for less experienced contributors to ease understanding and learning.
+- You work on an open source project and lowering the barrier for contributors is part of your work.
+
+## Project Overview
+
+The Nextcloud iOS Client is a tool to access and synchronize files from Nextcloud Server on your iPhone or iPad.
+Swift, UIKit and SwiftUI are the key technologies used for building the app on iOS.
+Beyond that, there is shared code in the form of the NextcloudKit library for use in macOS and iOS.
+Other platforms like Android are irrelevant for this project.
+
+## Project Structure: AI Agent Handling Guidelines
+
+| Directory       | Description                                         | Agent Action         |
+|-----------------|-----------------------------------------------------|----------------------|
+| `.github` | GitHub CI workflows. | Try to add unit tests for new features, where applicable and makes sense. Do not overcomplicate unit tests. |
+| `iOSClient` | Main iOS client source code. | — |
+| `iOSClient/SupportingFiles` | Translation files from Transifex. | Only add new strings in `en.lproj`. The rest you should ignore. |
+| `File Provider Extension` | Contains business logic for the iOS File Provider extension. | — |
+| `File Provider Extension UI` | Contains UI logic for the iOS File Provider extension. | — |
+| `Share` | Contains code for the iOS Share extension. | — |
+| `Widget` | Contains code for iOS Widgets. | — |
+| `WidgetDashboardIntentHandler` | Contains the intent handler for the dashboard widget. | — |
+| `Notification Service Extension` | Contains the push notification service extension. | — |
+| `Tests` | Contains unit and UI tests. | — |
+
+## General Guidance
+
+Every new file needs to get a SPDX header in the first rows according to this template. 
+The year in the first line must be replaced with the year when the file is created (for example, 2026 for files first added in 2026).
+The commenting signs need to be used depending on the file type.
+
+```plaintext
+SPDX-FileCopyrightText: <YEAR> Nextcloud GmbH and Nextcloud contributors
+SPDX-License-Identifier: GPL-2.0-or-later
+```
+
+Avoid creating source files that implement multiple types; instead, place each type in its own dedicated source file.
+
+## Commit and Pull Request Guidelines
+
+- **DCO sign-off (required)**: All commits must comply with the Developer Certificate of Origin (DCO) as described in `README.md` and include a `Signed-off-by: …` line in the commit message.
+- **Commits**: In addition to the DCO sign-off, follow the Conventional Commits format for the subject line where reasonable. Use `feat: ...`, `fix: ...`, or `refactor: ...` as appropriate in the commit message prefix.
+- Include a short summary of what changed. *Example:* `fix: prevent crash on empty todo title`.
+- **Pull Request**: When the agent creates a PR, it should include a description summarizing the changes and why they were made. If a GitHub issue exists, reference it (e.g., “Closes #123”). If there is any discrepancy between this section and the contribution guidance in `README.md`, the rules in `README.md` take precedence.
+
+## iOS Specifics
+
+The following details are important when working on the iOS client.
+
+### Requirements
+
+- Latest stable Xcode available is required to be installed in the development environment.
+
+### Code Style
+
+- When writing code in Swift, respect strict concurrency rules and Swift 6 compatibility.
+
+### Tests
+
+- When implementing new test suites, prefer Swift Testing over XCTest for implementation.
+- When implementing test cases using Swift Testing, do not prefix test method names with "test".
+- If the implementation of mock types is inevitable, implement them in dedicated source code files and in a generic way, so they can be reused across all tests in a test target.
+- If the implementation of an existing mock type does not fulfill the requirements introduced by new tests, prefer updating the existing type before implementing a mostly redundant alternative type.
+- Verify that all tests are passing and correct them if necessary.

AppIcon.icon/Assets/Nextcloud-logo-markonly-white.svg

@@ -0,0 +1,47 @@
+{
+  "fill" : {
+    "solid" : "display-p3:0.10980,0.68627,1.00000,1.00000"
+  },
+  "groups" : [
+    {
+      "layers" : [
+        {
+          "glass-specializations" : [
+            {
+              "value" : true
+            },
+            {
+              "idiom" : "square",
+              "value" : true
+            }
+          ],
+          "hidden" : false,
+          "image-name" : "Nextcloud-logo-markonly-white.svg",
+          "name" : "Nextcloud-logo-markonly-white",
+          "opacity" : 1,
+          "position" : {
+            "scale" : 7,
+            "translation-in-points" : [
+              0,
+              0
+            ]
+          }
+        }
+      ],
+      "shadow" : {
+        "kind" : "neutral",
+        "opacity" : 0.5
+      },
+      "translucency" : {
+        "enabled" : true,
+        "value" : 0.5
+      }
+    }
+  ],
+  "supported-platforms" : {
+    "circles" : [
+      "watchOS"
+    ],
+    "squares" : "shared"
+  }
+}

AppIcon.icon/icon.json

@@ -1,158 +1,14 @@
 {
   "images" : [
     {
-      "size" : "20x20",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon40@1x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "20x20",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon60@3x.png",
-      "scale" : "3x"
-    },
-    {
-      "size" : "29x29",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon29@1x.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "29x29",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon58@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "29x29",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon87@3x.png",
-      "scale" : "3x"
-    },
-    {
-      "size" : "40x40",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon80@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "40x40",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon120@3x.png",
-      "scale" : "3x"
-    },
-    {
-      "size" : "57x57",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon57@1x.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "57x57",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon114@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "60x60",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon120@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "60x60",
-      "idiom" : "iphone",
-      "filename" : "nextcloud-icon180@3x.png",
-      "scale" : "3x"
-    },
-    {
-      "size" : "20x20",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon20@1x.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "20x20",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon40@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "29x29",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon29@1x-1.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "29x29",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon58@2x-1.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "40x40",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon40@1x-1.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "40x40",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon80@2x-1.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "50x50",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon50@1x.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "50x50",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon100@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "72x72",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon72@1x.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "72x72",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon144@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "76x76",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon76@1x.png",
-      "scale" : "1x"
-    },
-    {
-      "size" : "76x76",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon152@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "83.5x83.5",
-      "idiom" : "ipad",
-      "filename" : "nextcloud-icon167@2x.png",
-      "scale" : "2x"
-    },
-    {
-      "size" : "1024x1024",
-      "idiom" : "ios-marketing",
-      "filename" : "nextcloud-icon1024@1x.png",
-      "scale" : "1x"
+      "filename" : "Icon-App-1024x1024@1x.png",
+      "idiom" : "universal",
+      "platform" : "ios",
+      "size" : "1024x1024"
     }
   ],
   "info" : {
-    "version" : 1,
-    "author" : "xcode"
+    "author" : "xcode",
+    "version" : 1
   }
-}
+}