Skip to content

Commit 06d3a80

Browse files
committed
fix: close button unresponsive on Android tablets in file picker modal
The modal-container__content element was receiving overflow-y: auto via the NMC theme override, turning it into a scroll container. On Android Chrome, this scroll container intercepts touch events in its rendered bounds — which overlaps with the absolutely-positioned close button (top: 0.5rem, right: 0.5rem). As a result, tapping the X button had no effect on Android tablets (tested on Samsung Galaxy Tab A8 / Android 14 and Lenovo Tab M10 / Android 12). NcDialog intentionally sets modal-container__content to overflow: hidden and handles scrolling one level deeper at dialog__content. The NMC override was defeating this by making the outer container a touch scroll target. Fix: separate the combined &__content, .dialog__content selector so that overflow-y: auto only applies to .dialog__content (where scrolling belongs), leaving modal-container__content without an overflow override. NcDialog's own scoped CSS (overflow: hidden) now applies correctly, eliminating the touch event interception on Android.
1 parent 86c7e70 commit 06d3a80

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

css/layouts/modal.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@
5959
touch-action: manipulation;
6060
}
6161

62-
&__content, .dialog__content {
63-
overflow-y: auto;
62+
&__content {
6463
padding-inline: 0;
6564

6665
.button-vue--vue-secondary {
@@ -126,6 +125,11 @@
126125
}
127126
}
128127

128+
.dialog__content {
129+
overflow-y: auto;
130+
padding-inline: 0;
131+
}
132+
129133
&:has(.modal__content--exif) {
130134
padding: 0;
131135

0 commit comments

Comments
 (0)