Skip to content

Fixes stops of stop groups getting lost during unplanning #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
merschformann wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fixes stops of stop groups getting lost during unplanning #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0561041
Avoiding unplanning of units units for vehicle and island heuristics
merschformann Nov 6, 2025
ba03513
Adding type check helper func
merschformann Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion solve_operator_unplan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,12 @@ func (d *solveOperatorUnPlanImpl) unplanOneIsland(
numberOfStops int,
) (int, error) {
planUnit := solution.PlannedPlanUnits().RandomElement()

// Reject island unplanning if it's a units-unit.
if isUnitsUnit(planUnit) {
return 0, nil
}

planStopsUnit := common.RandomElement(solution.Random(), planUnit.PlannedPlanStopsUnits())
for _, solutionStop := range planStopsUnit.(*solutionPlanStopsUnitImpl).solutionStops {
return d.unplanOneStopIsland(
Expand Down Expand Up @@ -222,10 +228,23 @@ func (d *solveOperatorUnPlanImpl) unplanSomeStopsOfOneVehicle(

for _, stop := range stops {
if stop.IsPlanned() && !stop.IsFixed() {
// TODO: should this be inverted (our chance is 0.2, so 80% chance
// to unplan - a.k.a. NOT skip unplanning)?
if solution.Random().Float64() < chance {
continue
}
unplanned, err := stop.PlanStopsUnit().UnPlan()

planStopsUnit := stop.PlanStopsUnit()

// // Get parent of unit to unplan full units.
// planStopsUnit := solution.PlannedPlanUnits().SolutionPlanUnit(stop.modelStop().planUnit)

// Reject unplanning if it's a units-unit.
if isUnitsUnit(planStopsUnit) {
continue
}

unplanned, err := planStopsUnit.UnPlan()
if err != nil {
return 0, err
}
Expand Down Expand Up @@ -271,3 +290,13 @@ func (d *solveOperatorUnPlanImpl) unplanLocation(

return count, nil
}

func isUnitsUnit(plannedPlanUnit SolutionPlanUnit) bool {
switch plannedPlanUnit.(type) {
case SolutionPlanStopsUnit:
return false
case SolutionPlanUnitsUnit:
return true
}
panic("unknown solution plan unit type")
}
Loading