Skip to content

chore: some updates#203

Merged
hmbanan666 merged 1 commit into
mainfrom
webinar-chore
Oct 7, 2025
Merged

chore: some updates#203
hmbanan666 merged 1 commit into
mainfrom
webinar-chore

Conversation

@hmbanan666
Copy link
Copy Markdown
Collaborator

@hmbanan666 hmbanan666 commented Oct 7, 2025

Summary by CodeRabbit

  • New Features

    • External links in footer and social buttons now open in a new tab.
    • Updated Telegram contact link to the new handle.
  • Style

    • Adjusted Hero section spacing: no top padding on small screens, retains larger-screen padding.
    • Updated WillKnow section container padding order to refine responsive spacing.

@hmbanan666 hmbanan666 self-assigned this Oct 7, 2025
@hmbanan666 hmbanan666 merged commit 572af0b into main Oct 7, 2025
5 checks passed
@hmbanan666 hmbanan666 deleted the webinar-chore branch October 7, 2025 09:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds per-item target handling for Footer and SocialButtons links, including opening in new tabs and updating a Telegram link. Adjusts responsive padding classes in Hero and WillKnow components to change top padding behavior, primarily on small screens. No exported/public API changes.

Changes

Cohort / File(s) Summary
Link target updates
apps/webinar/app/components/Footer.vue, apps/webinar/app/components/SocialButtons.vue
Footer: added per-item target binding ('_blank') for the mailto link. SocialButtons: set target="_blank" on all social links; updated first Telegram link from SLFranchiseBot to franshizasushi.
UI padding tweaks
apps/webinar/app/components/Hero.vue, apps/webinar/app/components/WillKnow.vue
Hero: set base pt-0 on small screens, keep lg:pt-24. WillKnow: reordered padding classes to pt-0 lg:pt-0 for container, affecting spacing application order.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • chore: some new blocks #196: Also updates Footer.vue and Hero.vue item/UI props; overlaps with link target and padding adjustments.
  • chore: update #197: Modifies Footer.vue item rendering (dynamic icon), intersecting with this PR’s per-item target handling.
  • feat: webinar app #181: Introduces the webinar app and its components; foundational to files modified here.

Poem

A rabbit taps links that open anew,
Stars pop like tabs in a midnight hue.
Padding lies flat, then rises at break,
Telegram’s trail finds a fresher wake.
Ears up—click, hop, layout just right,
Tiny tweaks, a smoother night.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch webinar-chore

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0b1ab and b289879.

📒 Files selected for processing (4)
  • apps/webinar/app/components/Footer.vue (1 hunks)
  • apps/webinar/app/components/Hero.vue (1 hunks)
  • apps/webinar/app/components/SocialButtons.vue (2 hunks)
  • apps/webinar/app/components/WillKnow.vue (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant