Skip to content

chore: some new columns#31

Merged
hmbanan666 merged 1 commit into
mainfrom
chore-metrics
Jul 31, 2025
Merged

chore: some new columns#31
hmbanan666 merged 1 commit into
mainfrom
chore-metrics

Conversation

@hmbanan666
Copy link
Copy Markdown
Collaborator

@hmbanan666 hmbanan666 commented Jul 31, 2025

Summary by CodeRabbit

  • New Features

    • Added new aggregate values for "checks" and "total" in kitchen revenue metrics.
    • Included "averageTotal" and "checks" fields in network metrics reporting.
  • Database Updates

    • Introduced new columns for "averageTotal" and "checks" in network metrics data.

@hmbanan666 hmbanan666 self-assigned this Jul 31, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 31, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce new aggregate fields, checks and averageTotal, into both the kitchen revenue data processing logic and the corresponding database schema. These fields are now calculated, rounded, and included when creating or updating network metrics. The database schema is updated to support these new columns.

Changes

Cohort / File(s) Change Summary
API Revenue Aggregation Logic
apps/web-app/server/api/kitchen/revenue/iiko-daily.post.ts
Adds calculation and rounding of checks and total across all kitchens; includes these in metric creation and update logic; renames total to averageTotal where appropriate.
Database Schema Update
packages/database/src/tables.ts
Adds averageTotal (numeric, default 0) and checks (integer, default 0) columns to the networkMetrics table schema.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API (iiko-daily.post.ts)
    participant Database

    Client->>API (iiko-daily.post.ts): Submit kitchen revenue data
    API (iiko-daily.post.ts)->>API (iiko-daily.post.ts): Parse and aggregate totals, checks, averageTotal, averageCheck
    API (iiko-daily.post.ts)->>Database: Create or update networkMetrics with totals, checks, averageTotal, averageCheck
    Database-->>API (iiko-daily.post.ts): Confirm write
    API (iiko-daily.post.ts)-->>Client: Respond with status
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • chore: some math #27: Also modifies iiko-daily.post.ts to add new aggregate fields for checks and totals in kitchen revenue processing.
  • feat: checks #23: Adds the checks metric to both the data processing logic and the database schema in the same file.

Poem

In the kitchen where numbers stew and boil,
We count the checks, let no totals spoil.
With columns new and logic neat,
Our metrics now are quite complete.
Hop, hop, the data grows—
A rabbit cheers as revenue flows! 🥕

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4442ce and 2fdb094.

📒 Files selected for processing (2)
  • apps/web-app/server/api/kitchen/revenue/iiko-daily.post.ts (2 hunks)
  • packages/database/src/tables.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-metrics

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hmbanan666 hmbanan666 merged commit c982abc into main Jul 31, 2025
5 of 6 checks passed
@hmbanan666 hmbanan666 deleted the chore-metrics branch July 31, 2025 09:57
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant