chore: removed old libs#36
Conversation
WalkthroughThis update removes build configuration files and scripts related to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ChartComponent
User->>ChartComponent: Hover over chart point
ChartComponent->>ChartComponent: Fetch date, day, checks count, average check, network average
ChartComponent->>User: Display tooltip with checks count (Russian plural), average check, network average
sequenceDiagram
participant TaskRunner
participant MetricsDB
participant RevenuesDB
TaskRunner->>MetricsDB: Get all existing network metrics
loop For each metric
TaskRunner->>RevenuesDB: Fetch all revenues for metric date
alt Revenues exist
TaskRunner->>TaskRunner: Sum checks and revenue
TaskRunner->>MetricsDB: Update metric with new sums
else No revenues
TaskRunner->>TaskRunner: Skip metric
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/geo-database/package.json (2)
9-17:cleanstill targetsdist/when no build artefacts are produced
With thebuild/postinstallscripts gone,dist/will never be created. Keeping thecleantarget creates dead-weight script noise.- "clean": "rm -rf dist", + "clean": "true" # or drop the script entirely
24-31: Stale dev-dependencies (unbuild,dotenv) after build removal
unbuildis only useful when a build step exists, anddotenvis usually tied todotenv/configimport removal observed elsewhere. Eliminating them trims install time and audit surface.- "dotenv": "catalog:", - "unbuild": "catalog:",packages/database/package.json (1)
6-8: Package now exports raw TypeScript – verify downstream compatibility
Consumers outside the repo (or even ESM loaders without ts-node/tsx) cannot execute.tsdirectly. Consider publishing transpiled JS or documenting that only workspace tooling is supported.apps/web-app/server/tasks/kitchen/average-update.ts (1)
18-20: Clean up commented code.The calculation logic is correct for summing checks and total revenue. However, consider removing the commented-out averageCheck calculation if it's no longer needed, or add a comment explaining why it's preserved.
const checks = allRevenuesThisPeriod.reduce((acc, curr) => acc + curr.checks, 0) -// const averageCheck = Math.round(allRevenuesThisPeriod.reduce((acc, curr) => acc + curr.averageCheck, 0) / allRevenuesThisPeriod.length) const total = Math.round(allRevenuesThisPeriod.reduce((acc, curr) => acc + curr.total, 0))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
apps/web-app/app/components/chart/KitchenChecks.client.vue(1 hunks)apps/web-app/server/tasks/kitchen/average-update.ts(1 hunks)k8s/web-parser/deployment.yaml(0 hunks)k8s/web-parser/secret.yaml(0 hunks)package.json(1 hunks)packages/database/build.config.ts(0 hunks)packages/database/drizzle.config.ts(0 hunks)packages/database/package.json(2 hunks)packages/geo-database/package.json(1 hunks)pnpm-workspace.yaml(0 hunks)
💤 Files with no reviewable changes (5)
- packages/database/drizzle.config.ts
- pnpm-workspace.yaml
- packages/database/build.config.ts
- k8s/web-parser/secret.yaml
- k8s/web-parser/deployment.yaml
🔇 Additional comments (6)
packages/database/package.json (1)
24-29: 👍 Dev-dependency list is leaner
Removal ofdotenvandunbuildis consistent with the simplified workflow.package.json (1)
6-6: LGTM on description tweak
The wording change is harmless and self-explanatory.apps/web-app/server/tasks/kitchen/average-update.ts (3)
10-10: Good refactoring approach.Fetching existing network metrics first is more efficient for an update operation, ensuring we only process metrics that already exist rather than potentially creating duplicates.
12-16: LGTM! Clean loop structure with proper guard clause.The refactored approach iterates over existing metrics and fetches relevant revenue data for each date. The guard clause efficiently skips processing when no revenue data exists.
22-25: Efficient update operation.The refactored code properly updates existing metrics using their IDs rather than creating new ones. This is more efficient and maintains data integrity.
apps/web-app/app/components/chart/KitchenChecks.client.vue (1)
130-130: Excellent localization enhancement.The tooltip template correctly implements Russian pluralization for check counts and provides comprehensive information. The pluralization forms ('чек', 'чека', 'чеков') are grammatically correct for Russian, enhancing the user experience for Russian-speaking users.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1 participant
Summary by CodeRabbit
New Features
Chores