Add IBM JSSE2 (ibmjava:8) TLS secret extraction support

IBM's JSSE2 provider classes are fully obfuscated, so the hook targets
TlsKeyMaterialGenerator.engineGenerateKey() in the unobfuscated JCE crypto
layer instead. The generator holds a TlsKeyMaterialParameterSpec field
exposing getClientRandom() and getMasterSecret(). Field lookup scans by
type to handle obfuscated field names that differ across IBMJCEPlus,
IBMJCE, FIPS, and PKCS11 providers.

- Add ibmjava:8 Dockerfile and test coverage for IBMJSSE2 in test.sh.
- Extend AgentMain unsupported-provider check to include IBMJSSE2.
- Add IBM attach API fallback (com.ibm.tools.attach.VirtualMachine) in AgentAttach.

Author: neykov

src/main/java/name/neykov/secrets/agent/AgentMain.java

@@ -176,7 +176,9 @@ private static void logSecurityProviders() {
         log.info("Registered TLS providers: " + Java6Compat.join(", ", names));
 
         String activeSslProvider = sslProviders[0].getName();
-        if (!activeSslProvider.equals("SunJSSE") && !activeSslProvider.equals("BCJSSE")) {
+        if (!activeSslProvider.equals("SunJSSE")
+                && !activeSslProvider.equals("BCJSSE")
+                && !activeSslProvider.equals("IBMJSSE2")) {
             log.warning(
                     "TLS provider '"
                             + activeSslProvider

src/main/java/name/neykov/secrets/agent/MasterSecretCallback.java

@@ -4,6 +4,7 @@
 import java.io.IOException;
 import java.io.Writer;
 import java.lang.reflect.Field;
+import java.lang.reflect.Method;
 import java.security.Key;
 import java.text.SimpleDateFormat;
 import java.util.Collections;
@@ -175,6 +176,37 @@ public static void onBcTls13ApplicationSecrets(Object tlsContext) {
         }
     }
 
+    // IBM Java 8 JSSE2 uses obfuscated internal classes; the stable hook is the
+    // TlsKeyMaterialGenerator. It holds a TlsKeyMaterialParameterSpec field that
+    // exposes getClientRandom() and getMasterSecret(). The field name is
+    // obfuscated and differs across provider implementations, so we scan
+    // declared fields by type rather than hardcoding a name.
+    @SuppressWarnings("unused")
+    public static void onIbmKeyMaterial(Object generator) {
+        try {
+            Object spec = null;
+            for (java.lang.reflect.Field f : generator.getClass().getDeclaredFields()) {
+                if (f.getType().getName().endsWith("TlsKeyMaterialParameterSpec")) {
+                    f.setAccessible(true);
+                    spec = f.get(generator);
+                    break;
+                }
+            }
+            if (spec == null) {
+                return;
+            }
+            Method getClientRandom = spec.getClass().getMethod("getClientRandom");
+            Method getMasterSecret = spec.getClass().getMethod("getMasterSecret");
+            byte[] clientRandom = (byte[]) getClientRandom.invoke(spec);
+            Key masterSecret = (Key) getMasterSecret.invoke(spec);
+            String clientRandomHex = bytesToHex(clientRandom);
+            String masterKeyHex = bytesToHex(masterSecret.getEncoded());
+            write("CLIENT_RANDOM " + clientRandomHex + " " + masterKeyHex);
+        } catch (Exception e) {
+            log.log(Level.WARNING, "Error retrieving IBM JSSE2 master secret.", e);
+        }
+    }
+
     private static String getConnectionDetails(SSLSession sslSession) {
         String dateNow;
         synchronized (DATE_FMT) {

src/main/java/name/neykov/secrets/agent/Transformer.java

@@ -19,6 +19,7 @@
 public class Transformer implements ClassFileTransformer {
     private static final Logger log = Logger.getLogger(Transformer.class.getName());
     private static final AtomicBoolean bcjsseLogged = new AtomicBoolean(false);
+    private static final AtomicBoolean ibmjsse2Logged = new AtomicBoolean(false);
 
     private static void logBcjsseDetected() {
         if (bcjsseLogged.compareAndSet(false, true)) {
@@ -30,6 +31,12 @@ private static void logBcjsseDetected() {
         }
     }
 
+    private static void logIbmJsse2Detected() {
+        if (ibmjsse2Logged.compareAndSet(false, true)) {
+            log.info("IBM JSSE2 detected and instrumented.");
+        }
+    }
+
     private static String getBcVersion() {
         try {
             ClassLoader cl = Thread.currentThread().getContextClassLoader();
@@ -161,13 +168,39 @@ protected void instrumentClass(CtClass instrumentedClass)
         }
     }
 
+    // IBM Java 8's JSSE2 provider classes are obfuscated; the stable hook is the
+    // TlsKeyMaterialGenerator in the crypto layer, which holds both the master
+    // secret and the client random in its TlsKeyMaterialParameterSpec field.
+    // Multiple provider implementations exist (IBMJCEPlus, IBMJCE, FIPS, PKCS11);
+    // the callback resolves the spec field via reflection so a single injected
+    // expression covers all of them.
+    private static class IbmKeyMaterialInjectCallback extends InjectCallback {
+        public IbmKeyMaterialInjectCallback() {
+            super(
+                    "com.ibm.crypto.plus.provider.TlsKeyMaterialGenerator",
+                    "com.ibm.crypto.provider.TlsKeyMaterialGenerator",
+                    "com.ibm.crypto.fips.provider.TlsKeyMaterialGenerator",
+                    "com.ibm.crypto.pkcs11impl.provider.PKCS11TlsKeyMaterialGenerator");
+        }
+
+        @Override
+        protected void instrumentClass(CtClass instrumentedClass)
+                throws CannotCompileException, NotFoundException {
+            String cb = MasterSecretCallback.class.getName();
+            CtMethod method = instrumentedClass.getDeclaredMethod("engineGenerateKey");
+            method.insertBefore(cb + ".onIbmKeyMaterial((java.lang.Object)this);");
+            logIbmJsse2Detected();
+        }
+    }
+
     private static final InjectCallback[] TRANSFORMERS =
             new InjectCallback[] {
                 new SessionInjectCallback(),
                 new HandshakerInjectCallback(),
                 new SSLTrafficKeyDerivation(),
                 new BcTlsProtocolInjectCallback(),
-                new BcTlsUtilsInjectCallback()
+                new BcTlsUtilsInjectCallback(),
+                new IbmKeyMaterialInjectCallback()
             };
 
     @Override

src/main/java/name/neykov/secrets/cli/AgentAttach.java

@@ -141,7 +141,16 @@ private static boolean isAttachApiAvailable() {
             AgentAttach.class.getClassLoader().loadClass("com.sun.tools.attach.VirtualMachine");
             return true;
         } catch (ClassNotFoundException e) {
-            return false;
+            // IBM Java 8 ships its own attach API under com.ibm.tools.attach.
+            // IBM's tools.jar also provides com.sun.tools.attach as a wrapper,
+            // so AttachHelper (which uses com.sun.tools.attach) works once
+            // tools.jar is on the classpath.
+            try {
+                AgentAttach.class.getClassLoader().loadClass("com.ibm.tools.attach.VirtualMachine");
+                return true;
+            } catch (ClassNotFoundException e2) {
+                return false;
+            }
         }
     }
 }

src/test/docker/Dockerfile.ibmjdk8

@@ -0,0 +1,2 @@
+FROM ibmjava:8
+VOLUME /secrets /project

src/test/docker/test.sh

@@ -31,9 +31,22 @@ PROVIDERS="JSSE BCJSSE"
 
 JSSE_SKIP=""
 JSSE_MARKER="CipherSuite:"
+JSSE_SSL_PROVIDER="SunJSSE"
 
 BCJSSE_SKIP=""
 BCJSSE_MARKER="BCJSSE CipherSuite:"
+# BCJSSE is registered by the application after premain; not visible in the
+# agent's initial provider log. Leave unset so check_provider_logs skips it.
+BCJSSE_SSL_PROVIDER=""
+
+# IBM JSSE2 — ibmjava:8 (IBM SDK for Java 8, IBM J9 JVM) registers IBMJSSE2 as
+# provider #1 before premain; the provider-name check is valid for that image.
+# ibm-semeru-runtimes (open edition) uses SunJSSE and is covered by JSSE above.
+IBMJSSE2_SKIP=""
+# IBM's TlsKeyMaterialGenerator hook writes CLIENT_RANDOM directly without a
+# comment line (no SSL session available at the crypto layer).
+IBMJSSE2_MARKER="CLIENT_RANDOM"
+IBMJSSE2_SSL_PROVIDER="IBMJSSE2"
 # ──────────────────────────────────────────────────────────────────────────
 
 # ── BC compat matrix ───────────────────────────────────────────────────────
@@ -122,8 +135,12 @@ start_server() {
 # Usage: check_provider_logs <provider> <inject_type>
 check_provider_logs() {
   local provider="$1" inject_type="$2"
-  local ssl_provider
   wait_for_log ssl-secrets-server "Registered TLS providers"
+  local ssl_provider_var="${provider}_SSL_PROVIDER"
+  local expected_provider="${!ssl_provider_var}"
+  if [ -n "$expected_provider" ]; then
+    wait_for_log ssl-secrets-server "Registered TLS providers:.*$expected_provider"
+  fi
 }
 
 # Verify that a captured pcap can be decrypted using the given keylog file.
@@ -346,4 +363,25 @@ for BC_VERSION in $BC_COMPAT_VERSIONS; do
 
 done
 
+# ══════════════════════════════════════════════════════════════════════════════
+#  IBM SDK for Java 8 (ibmjava:8): IBM J9 JVM + IBMJSSE2 provider
+#  This is the JVM used by HCL Notes 12 and similar IBM products.
+#  TLSv1.3 is not supported by IBM Java 8.
+# ══════════════════════════════════════════════════════════════════════════════
+
+run_ibm_jdk8_tests() {
+  echo -e "\n" \
+    "=============================================\n" \
+    "   IBM SDK for Java 8 (IBMJSSE2) \n" \
+    "=============================================\n\n"
+  docker rm -f $(docker ps -qa) 2>/dev/null || true
+  docker build -f $CWD/Dockerfile.ibmjdk8 $CWD -t ssl-secrets-server
+
+  local marker="${IBMJSSE2_MARKER}"
+  start_server "$DEFAULT_CP" "IBMJSSE2"
+  run_proto_test "TLSv1.2" "$DEFAULT_CP" "IBMJSSE2" "$marker"
+}
+
+run_ibm_jdk8_tests
+
 docker rm -f ssl-secrets-server