Skip to content

Commit 339f30a

Browse files
committed
Address gcta addgrms review comments
1 parent 5962c65 commit 339f30a

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

modules/nf-core/gcta/addgrms/main.nf

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ process GCTA_ADDGRMS {
22
tag "${meta.id}"
33
label 'process_medium'
44
conda "${moduleDir}/environment.yml"
5-
container "${workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container
5+
container "${workflow.containerEngine in ['singularity', 'apptainer'] && !task.ext.singularity_pull_docker_container
66
? 'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/46/46b0d05f0daa47561d87d2a9cac5e51edc2c78e26f1bbab439c688386241a274/data'
77
: 'community.wave.seqera.io/library/gcta:1.94.1--9bc35dc424fcf6e9'}"
88

@@ -17,17 +17,15 @@ process GCTA_ADDGRMS {
1717
task.ext.when == null || task.ext.when
1818

1919
script:
20-
def extra_args = task.ext.args ?: ''
20+
def args = task.ext.args ?: ''
2121
def prefix = task.ext.prefix ?: "${meta.id}"
22-
2322
"""
24-
2523
gcta \\
2624
--mgrm ${mgrm_file} \\
2725
--make-grm \\
2826
--out ${prefix} \\
2927
--thread-num ${task.cpus} \\
30-
${extra_args}
28+
${args}
3129
"""
3230

3331
stub:

modules/nf-core/gcta/addgrms/tests/main.nf.test

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ nextflow_process {
8080
}
8181

8282
test("homo_sapiens popgen - merge dense GRMs from mgrm") {
83-
config "./nextflow.config"
84-
8583
when {
8684
process {
8785
"""
@@ -126,7 +124,6 @@ nextflow_process {
126124

127125
test("homo_sapiens popgen - merge dense GRMs from mgrm - stub") {
128126
options "-stub"
129-
config "./nextflow.config"
130127

131128
when {
132129
process {

0 commit comments

Comments
 (0)