Add new component: gridss/preprocess#11988
Conversation
5e69d6b to
546055c
Compare
| stripPicardHeaderMd5("${workdir}/${prefix}.insert_size_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.mapq_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.tag_metrics"), | ||
| process.out.findAll { key, val -> key.startsWith("versions") } |
There was a problem hiding this comment.
I believe that with nf-test 0.9.5, which the CI for this repo already has, this can be done simply by:
| process.out.findAll { key, val -> key.startsWith("versions") } | |
| topics |
Provided that topics "versions" is added above.
There was a problem hiding this comment.
Or even just process.out.versions_gridss? 🤔
There was a problem hiding this comment.
process.out.findAll { key, val -> key.startsWith("versions") } is the standard way we have been using in the repo at the moment.
| process.out.preprocess_dir.collect { meta, dir -> [meta, file(dir).list().findAll { it.startsWith(prefix) }.sort()] }, | ||
| path("${workdir}/${prefix}.computesamtags.changes.tsv"), | ||
| path("${workdir}/${prefix}.coverage.blacklist.bed"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.cigar_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.idsv_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.insert_size_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.mapq_metrics"), | ||
| stripPicardHeaderMd5("${workdir}/${prefix}.tag_metrics"), |
There was a problem hiding this comment.
I think lines 60-67 are actually testing the tool, not the module. The behaviour of the tool should be tested in the tool itself. For the nextflow module, I would think checking the process outputs is suficient.
| process.out.preprocess_dir.collect { meta, dir -> [meta, file(dir).list().findAll { it.startsWith(prefix) }.sort()] }, | |
| path("${workdir}/${prefix}.computesamtags.changes.tsv"), | |
| path("${workdir}/${prefix}.coverage.blacklist.bed"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.cigar_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.idsv_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.insert_size_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.mapq_metrics"), | |
| stripPicardHeaderMd5("${workdir}/${prefix}.tag_metrics"), | |
| process.out |
Looking at the tests for cadd for example, that seems to be the case. 🤔
| versions: | ||
| - - ${task.process}: | ||
| type: string | ||
| description: The process |
There was a problem hiding this comment.
| description: The process | |
| description: The name of the process |
As a part of the distributed computing GRIDSS subworkflow #4498 , I added this gridss/preprocess module. This pre-processing step in GRIDSS extracts multiple Picard metrics (insert size, MAPQ, CIGAR, IDSV, tag, and coverage) from an input BAM file prior to assembly and variant calling.
PR checklist
Closes #4499
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda