Readd dataset version extraction#12026
Open
ammaraziz wants to merge 9 commits into
Open
Conversation
Contributor
Author
|
Hi @MarieLataretu pinging you for review as you were the last updater of this module from Thanks! |
Contributor
|
Hi @ammaraziz, I have smaller comments, but looks great otherwise 🙂 |
MarieLataretu
previously requested changes
Jun 17, 2026
| versions_nextclade_dataset: | ||
| - - ${task.process}: | ||
| type: string | ||
| description: The process the process |
Contributor
There was a problem hiding this comment.
Suggested change
| description: The process the process | |
| description: The process the versions were collected from |
Co-authored-by: MarieLataretu <52002068+MarieLataretu@users.noreply.github.com>
jfy133
reviewed
Jun 24, 2026
| "2": [ | ||
| [ | ||
| "NEXTCLADE_DATASETGET", | ||
| "nextclade-dataset", |
Member
There was a problem hiding this comment.
This hasn't picked up the version? Something to check.
Member
There was a problem hiding this comment.
If it's from the stub, maybe dummy-fy a version string so it still works with the version capture
| "versions_nextclade_dataset": [ | ||
| [ | ||
| "NEXTCLADE_DATASETGET", | ||
| "nextclade-dataset", |
| versions_nextclade_dataset: | ||
| - - ${task.process}: | ||
| type: string | ||
| description: The process the process |
jfy133
dismissed
MarieLataretu’s stale review
Blocking even if second reviewer approves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
The change from versions.yaml to channels unfortunately dropped the dataset version. This PR adds it back.
topic: versions- See version_topicsFingers crossed this works!