Skip to content

add-new-tool: rami2d/register and rami2d/transform#12027

Open
kubranarci wants to merge 11 commits into
nf-core:masterfrom
kubranarci:rami2d-addnew-module
Open

add-new-tool: rami2d/register and rami2d/transform#12027
kubranarci wants to merge 11 commits into
nf-core:masterfrom
kubranarci:rami2d-addnew-module

Conversation

@kubranarci

@kubranarci kubranarci commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@kubranarci kubranarci self-assigned this Jun 17, 2026
@kubranarci kubranarci added new module Adding a new module imaging labels Jun 17, 2026
@kubranarci kubranarci requested a review from kbestak June 17, 2026 11:20
Comment thread modules/nf-core/rami2d/register/environment.yml Outdated
kubranarci and others added 2 commits June 18, 2026 10:17
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Comment thread modules/nf-core/rami2d/register/environment.yml Outdated
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Comment thread modules/nf-core/rami2d/transform/environment.yml Outdated
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@migueLib migueLib enabled auto-merge June 18, 2026 11:26
@migueLib migueLib disabled auto-merge June 18, 2026 11:26

@migueLib migueLib left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


output:
tuple val(meta), path("${prefix}/*.ome.tif"), emit: registered_image
tuple val(meta), path("${prefix}/*.csv") , emit: csv, optional: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no .csv output file. There is a .csv input for the -m argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imaging new module Adding a new module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants