Add finaletoolkit/endmotifs#12035
Merged
Merged
Conversation
From the upstream documentation: > Measures frequency of k-mer 5’ end motifs.
SPPearce
approved these changes
Jun 23, 2026
SPPearce
left a comment
Contributor
There was a problem hiding this comment.
Can the tool cope with cram files?
Contributor
Author
|
@SPPearce the newest version supports CRAM (not the one we have here), but if you don't mind I'll add first all the tools then make a sweeping follow-up PR to update versions and inputs in all the modules (I need one more PR for one last subcommand). Would that be OK? |
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Contributor
Sure, it was mostly just to detail that in the meta.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is yet another subtool from Finale Toolkit. From the upstream documentation:
It is required to land support for another tool which computes Motif Diversity Score (MDS).
PR checklist
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda