Skip to content

Add finaletoolkit/endmotifs#12035

Merged
lbeltrame merged 10 commits into
nf-core:masterfrom
DIncalciLab:finale-mds
Jun 23, 2026
Merged

Add finaletoolkit/endmotifs#12035
lbeltrame merged 10 commits into
nf-core:masterfrom
DIncalciLab:finale-mds

Conversation

@lbeltrame

@lbeltrame lbeltrame commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This is yet another subtool from Finale Toolkit. From the upstream documentation:

Measures frequency of k-mer 5’ end motifs.

It is required to land support for another tool which computes Motif Diversity Score (MDS).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

From the upstream documentation:

> Measures frequency of k-mer 5’ end motifs.
@lbeltrame lbeltrame self-assigned this Jun 18, 2026

@SPPearce SPPearce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the tool cope with cram files?

Comment thread modules/nf-core/finaletoolkit/endmotifs/main.nf Outdated
Comment thread modules/nf-core/finaletoolkit/endmotifs/main.nf Outdated
@lbeltrame

Copy link
Copy Markdown
Contributor Author

@SPPearce the newest version supports CRAM (not the one we have here), but if you don't mind I'll add first all the tools then make a sweeping follow-up PR to update versions and inputs in all the modules (I need one more PR for one last subcommand).

Would that be OK?

lbeltrame and others added 2 commits June 23, 2026 13:26
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@lbeltrame lbeltrame enabled auto-merge June 23, 2026 11:27
@lbeltrame lbeltrame added this pull request to the merge queue Jun 23, 2026
Merged via the queue into nf-core:master with commit f590526 Jun 23, 2026
23 checks passed
@lbeltrame lbeltrame deleted the finale-mds branch June 23, 2026 11:37
@SPPearce

Copy link
Copy Markdown
Contributor

@SPPearce the newest version supports CRAM (not the one we have here), but if you don't mind I'll add first all the tools then make a sweeping follow-up PR to update versions and inputs in all the modules (I need one more PR for one last subcommand).

Would that be OK?

Sure, it was mostly just to detail that in the meta.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants