Skip to content

Add round_digits to decoupler and avoid sorting by topTable in dream#12114

Merged
dialvarezs merged 2 commits into
nf-core:masterfrom
atrigila:diff_abundance_fixes
Jun 19, 2026
Merged

Add round_digits to decoupler and avoid sorting by topTable in dream#12114
dialvarezs merged 2 commits into
nf-core:masterfrom
atrigila:diff_abundance_fixes

Conversation

@atrigila

@atrigila atrigila commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

decoupler was not using the round_digits feature that we have in nf-core/differentialabundance. The changes here fix that. Additionally, in dream, we do not rely on topTable to automatically sort rows, which was causing also some instability.
In the dream test there is also a removal of an obsolete test.

For: nf-core/differentialabundance#745

@atrigila atrigila marked this pull request as ready for review June 19, 2026 17:46
@atrigila atrigila requested a review from pinin4fjords as a code owner June 19, 2026 17:46
@atrigila atrigila changed the title Add round_digits to dream and decoupler Add round_digits to decoupler and avoid sorting by topTable in dream Jun 19, 2026
@atrigila atrigila self-assigned this Jun 19, 2026
@dialvarezs dialvarezs enabled auto-merge June 19, 2026 20:39

@dialvarezs dialvarezs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dialvarezs dialvarezs added this pull request to the merge queue Jun 19, 2026
Merged via the queue into nf-core:master with commit 95a5fb2 Jun 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants