Skip to content

Commit 762cb4c

Browse files
authored
Merge branch 'dev' into olgabot/add-metromap
2 parents 819d7cf + 9756277 commit 762cb4c

39 files changed

Lines changed: 676 additions & 1574 deletions

.github/workflows/awsfulltest.yml

Lines changed: 10 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -4,44 +4,23 @@ name: nf-core AWS full size tests
44
# It runs the -profile 'test_full' on AWS batch
55

66
on:
7-
pull_request:
8-
branches:
9-
- main
10-
- master
117
workflow_dispatch:
128
pull_request_review:
139
types: [submitted]
10+
release:
11+
types: [published]
1412

1513
jobs:
1614
run-platform:
1715
name: Run AWS full tests
18-
# run only if the PR is approved by at least 2 reviewers and against the master branch or manually triggered
19-
if: github.repository == 'nf-core/proteinannotator' && github.event.review.state == 'approved' && github.event.pull_request.base.ref == 'master' || github.event_name == 'workflow_dispatch'
16+
# run only if the PR is approved by at least 2 reviewers and against the master/main branch or manually triggered
17+
if: github.repository == 'nf-core/proteinannotator' && github.event.review.state == 'approved' && (github.event.pull_request.base.ref == 'master' || github.event.pull_request.base.ref == 'main') || github.event_name == 'workflow_dispatch'
2018
runs-on: ubuntu-latest
2119
steps:
22-
- name: Get PR reviews
23-
uses: octokit/request-action@v2.x
24-
if: github.event_name != 'workflow_dispatch'
25-
id: check_approvals
26-
continue-on-error: true
27-
with:
28-
route: GET /repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews?per_page=100
29-
env:
30-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
31-
32-
- name: Check for approvals
33-
if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
34-
run: |
35-
echo "No review approvals found. At least 2 approvals are required to run this action automatically."
36-
exit 1
37-
38-
- name: Check for enough approvals (>=2)
39-
id: test_variables
40-
if: github.event_name != 'workflow_dispatch'
20+
- name: Set revision variable
21+
id: revision
4122
run: |
42-
JSON_RESPONSE='${{ steps.check_approvals.outputs.data }}'
43-
CURRENT_APPROVALS_COUNT=$(echo $JSON_RESPONSE | jq -c '[.[] | select(.state | contains("APPROVED")) ] | length')
44-
test $CURRENT_APPROVALS_COUNT -ge 2 || exit 1 # At least 2 approvals are required
23+
echo "revision=${{ (github.event_name == 'workflow_dispatch' || github.event_name == 'release') && github.sha || 'dev' }}" >> "$GITHUB_OUTPUT"
4524
4625
- name: Launch workflow via Seqera Platform
4726
uses: seqeralabs/action-tower-launch@v2
@@ -52,12 +31,12 @@ jobs:
5231
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
5332
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
5433
compute_env: ${{ secrets.TOWER_COMPUTE_ENV }}
55-
revision: ${{ github.sha }}
56-
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/proteinannotator/work-${{ github.sha }}
34+
revision: ${{ steps.revision.outputs.revision }}
35+
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/proteinannotator/work-${{ steps.revision.outputs.revision }}
5736
parameters: |
5837
{
5938
"hook_url": "${{ secrets.MEGATESTS_ALERTS_SLACK_HOOK_URL }}",
60-
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/proteinannotator/results-${{ github.sha }}"
39+
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/proteinannotator/results-${{ steps.revision.outputs.revision }}"
6140
}
6241
profiles: test_full
6342

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,5 +83,6 @@ jobs:
8383
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
8484

8585
- name: "Run pipeline with test data ${{ matrix.NXF_VER }} | ${{ matrix.test_name }} | ${{ matrix.profile }}"
86+
continue-on-error: ${{ matrix.NXF_VER == 'latest-everything' }}
8687
run: |
8788
nextflow run ${GITHUB_WORKSPACE} -profile ${{ matrix.test_name }},${{ matrix.profile }} --outdir ./results

.nf-core.yml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,20 @@
1+
lint:
2+
files_unchanged:
3+
- assets/nf-core-proteinannotator_logo_light.png
4+
- docs/images/nf-core-proteinannotator_logo_light.png
5+
- docs/images/nf-core-proteinannotator_logo_dark.png
6+
nf_core_version: 3.2.1
17
repository_type: pipeline
2-
3-
nf_core_version: 3.2.0
4-
5-
lint: {}
6-
78
template:
8-
org: nf-core
9-
name: proteinannotator
9+
author: Olga Botvinnik
1010
description: The best protein annotation pipeline in the world. Protein fasta ->
1111
??? -> Annotations!
12-
author: Olga Botvinnik
1312
version: 1.0.0dev
1413
force: true
1514
outdir: .
15+
skip_features:
16+
- fastqc
17+
- igenomes
1618
is_nfcore: true
19+
name: proteinannotator
20+
org: nf-core

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ Initial release of nf-core/proteinannotator, created with the [nf-core](https://
99

1010
### `Added`
1111

12+
- [[PR #13](https://github.com/nf-core/proteinannotator/pull/13)] Add nf-core seqkit/stats module
13+
1214
### `Fixed`
1315

1416
### `Dependencies`

CITATIONS.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010
1111
## Pipeline tools
1212

13-
- [FastQC](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/)
14-
15-
> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online].
16-
1713
- [MultiQC](https://pubmed.ncbi.nlm.nih.gov/27312411/)
1814

1915
> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924.

README.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,26 +36,23 @@
3636

3737
![Protein annotator metromap. Protein fasta files are summarized with `seqkit stats`, then functionally annotated with InterProScan, DIAMOND-blastp, UniFire, and Kmerseek](assets/proteinannotator-metromap.excalidraw.png)
3838

39+
3940
## Usage
4041

4142
> [!NOTE]
4243
> If you are new to Nextflow and nf-core, please refer to [this page](https://nf-co.re/docs/usage/installation) on how to set-up Nextflow. Make sure to [test your setup](https://nf-co.re/docs/usage/introduction#how-to-run-a-pipeline) with `-profile test` before running the workflow on actual data.
4344
44-
<!-- TODO nf-core: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
45-
Explain what rows and columns represent. For instance (please edit as appropriate):
46-
4745
First, prepare a samplesheet with your input data that looks as follows:
4846

4947
`samplesheet.csv`:
5048

5149
```csv
52-
sample,fastq_1,fastq_2
53-
CONTROL_REP1,AEG588A1_S1_L002_R1_001.fastq.gz,AEG588A1_S1_L002_R2_001.fastq.gz
50+
id,fasta
51+
species1,species1_proteins.fasta
52+
species2,species2_proteins.fasta
5453
```
5554

56-
Each row represents a fastq file (single-end) or a pair of fastq files (paired end).
57-
58-
-->
55+
Each row represents a fasta file of proteins from a single species.
5956

6057
Now, you can run the pipeline using:
6158

52 Bytes
Loading

assets/samplesheet.csv

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
sample,fastq_1,fastq_2
2-
SAMPLE_PAIRED_END,/path/to/fastq/files/AEG588A1_S1_L002_R1_001.fastq.gz,/path/to/fastq/files/AEG588A1_S1_L002_R2_001.fastq.gz
3-
SAMPLE_SINGLE_END,/path/to/fastq/files/AEG588A4_S4_L003_R1_001.fastq.gz,
1+
id,fasta
2+
species1,species1_proteins.fasta
3+
species2,species2_proteins.fasta

assets/schema_input.json

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,20 @@
77
"items": {
88
"type": "object",
99
"properties": {
10-
"sample": {
10+
"id": {
1111
"type": "string",
1212
"pattern": "^\\S+$",
1313
"errorMessage": "Sample name must be provided and cannot contain spaces",
1414
"meta": ["id"]
1515
},
16-
"fastq_1": {
16+
"fasta": {
1717
"type": "string",
1818
"format": "file-path",
1919
"exists": true,
20-
"pattern": "^\\S+\\.f(ast)?q\\.gz$",
21-
"errorMessage": "FastQ file for reads 1 must be provided, cannot contain spaces and must have extension '.fq.gz' or '.fastq.gz'"
22-
},
23-
"fastq_2": {
24-
"type": "string",
25-
"format": "file-path",
26-
"exists": true,
27-
"pattern": "^\\S+\\.f(ast)?q\\.gz$",
28-
"errorMessage": "FastQ file for reads 2 cannot contain spaces and must have extension '.fq.gz' or '.fastq.gz'"
20+
"pattern": "^\\S+\\.f(ast)?a(\\.gz)?$",
21+
"errorMessage": "Fasta file for each sample must be provided, cannot contain spaces and must have extension '.fa.gz', '.fa', '.fasta', or '.fasta.gz'"
2922
}
3023
},
31-
"required": ["sample", "fastq_1"]
24+
"required": ["id", "fasta"]
3225
}
3326
}

0 commit comments

Comments
 (0)