Skip to content

Added NF-test and meta.yml #86

Closed
Muskan-2464 wants to merge 5 commits into
mainfrom
patch-functional-annotations
Closed

Added NF-test and meta.yml #86
Muskan-2464 wants to merge 5 commits into
mainfrom
patch-functional-annotations

Conversation

@Muskan-2464

@Muskan-2464 Muskan-2464 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/proteinannotator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (e.g. nf-test test */local --profile=~test,docker for all new local tests).
  • Check for unexpected warnings in debug mode (nf-test test */local --profile=~test,docker,debug).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@Muskan-2464
Create meta.yml
e74b2f3 
This PR adds the missing meta.yml and nf-test for functional annotation as a part of March 2025 Hackathon.
@Muskan-2464
meta.yml
0e9b000 
added meta.yml file
@Muskan-2464
Create nf test
340d27b 
 nf test 21
@Muskan-2464
meta.yml6
a00141d
@Muskan-2464
nf test
2717a61
@github-actions

github-actions Bot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2717a61

+| ✅ 214 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-03-12 13:29:09

@Muskan-2464 Muskan-2464 marked this pull request as ready for review March 12, 2026 13:33
@Muskan-2464 Muskan-2464 changed the title Patch-nftest-yml-file Added NF-test and meta.yml Mar 12, 2026
@nf-core nf-core deleted a comment from github-actions Bot Mar 12, 2026
@camlloyd

camlloyd commented Mar 12, 2026

Copy link
Copy Markdown
Member

I think you need to rename your test file.

@vagkaratzas

vagkaratzas commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Open this PR against dev instead of main

vagkaratzas
vagkaratzas reviewed Mar 12, 2026
View reviewed changes

@vagkaratzas vagkaratzas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow the nf-core guidelines on what files to make and how to name...see other local subworkflows for example, and how to name files

@Muskan-2464 Muskan-2464 deleted the patch-functional-annotations branch March 13, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vagkaratzas vagkaratzas vagkaratzas left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Muskan-2464 @camlloyd @vagkaratzas