Skip to content

Add Interproscan#9

Merged
olgabot merged 169 commits into
devfrom
olgabot/add-interproscan
Jun 24, 2025
Merged

Add Interproscan#9
olgabot merged 169 commits into
devfrom
olgabot/add-interproscan

Conversation

@olgabot
Copy link
Copy Markdown
Collaborator

@olgabot olgabot commented Mar 24, 2025

  • Add interproscan module
  • Got test input to work

Addresses: #3

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/proteinannotator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@heuermh
Copy link
Copy Markdown
Contributor

heuermh commented Mar 24, 2025

@olgabot could you push an empty commit to this branch? Github Actions wasn't enabled when the pull request was created

$ git commit --allow-empty -m "Enable GitHub Actions CI on this pull request"
$ git push

@olgabot
Copy link
Copy Markdown
Collaborator Author

olgabot commented Mar 25, 2025

@heuermh, will do! Wanted to also report this docker build error on my M2 mac, which is probably an architecture issue

(nf-core-v2) 
 ✘  Mon 24 Mar - 16:15  ~/code/nf-core/modules/modules/nf-core/interproscan   origin ☊ master 3☀ 2● 
  docker build . -t quay.io/nf-core/interproscan:5.73-104.0
[+] Building 23.9s (10/12)                                                                                                                                                         docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                                                                                               0.0s
 => => transferring dockerfile: 1.94kB                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/mambaorg/micromamba:2.0.5                                                                                                                               0.4s
 => [internal] load .dockerignore                                                                                                                                                                  0.0s
 => => transferring context: 2B                                                                                                                                                                    0.0s
 => [internal] load build context                                                                                                                                                                  0.0s
 => => transferring context: 9.72kB                                                                                                                                                                0.0s
 => [1/8] FROM docker.io/mambaorg/micromamba:2.0.5@sha256:8d0d4cad074afe3ac93b58dce88bd2659153d3fa6de3a6968f501710e8d3c832                                                                         1.6s
 => => resolve docker.io/mambaorg/micromamba:2.0.5@sha256:8d0d4cad074afe3ac93b58dce88bd2659153d3fa6de3a6968f501710e8d3c832                                                                         0.0s
 => => sha256:ca8feed3070834bddfa15ffdc519c000852c511f2682af29fd9dfa6fe72d926d 5.86kB / 5.86kB                                                                                                     0.0s
 => => sha256:0996a45dbf081690ef07d06d966daaf33ddccd439dcfe9092dec0cd7bf53e768 122.68kB / 122.68kB                                                                                                 0.5s
 => => sha256:c24f4d9717cc8ead02156bf9ead4a0943dfe7cbf84cb9f4a6b08600f1e263c5b 548B / 548B                                                                                                         0.3s
 => => sha256:8d0d4cad074afe3ac93b58dce88bd2659153d3fa6de3a6968f501710e8d3c832 2.36kB / 2.36kB                                                                                                     0.0s
 => => sha256:7c1325c9891758c8fbb14afa52f5c75ac38c12c9bf0ba8b8d9a37118480284fb 2.18kB / 2.18kB                                                                                                     0.0s
 => => sha256:8d442fcb0ca8120ef7c558109e962bc23e5b9991714a43d11f1255981a5c91ec 8.38MB / 8.38MB                                                                                                     1.0s
 => => sha256:c14b2f689c1b34cb8d9f268f7db19a54408a5a57c01ff7b6a4e57c65765c792c 283B / 283B                                                                                                         0.5s
 => => sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1 32B / 32B                                                                                                           0.7s
 => => sha256:bd1693c48ea5c20426b078e87b857fdc684a0973f0a6baae2ce010f6f6003b13 3.79kB / 3.79kB                                                                                                     0.9s
 => => sha256:ad9621110251bbf75f24aaa0c4b52e0802d11bc590921015401adda364b78b19 681B / 681B                                                                                                         1.1s
 => => sha256:a69ca0ecce5760df4d789643fca9750fb31a934c16d235cb32df678cb49124a4 644B / 644B                                                                                                         1.3s
 => => extracting sha256:8d442fcb0ca8120ef7c558109e962bc23e5b9991714a43d11f1255981a5c91ec                                                                                                          0.1s
 => => extracting sha256:0996a45dbf081690ef07d06d966daaf33ddccd439dcfe9092dec0cd7bf53e768                                                                                                          0.0s
 => => extracting sha256:c24f4d9717cc8ead02156bf9ead4a0943dfe7cbf84cb9f4a6b08600f1e263c5b                                                                                                          0.0s
 => => extracting sha256:c14b2f689c1b34cb8d9f268f7db19a54408a5a57c01ff7b6a4e57c65765c792c                                                                                                          0.0s
 => => extracting sha256:bd1693c48ea5c20426b078e87b857fdc684a0973f0a6baae2ce010f6f6003b13                                                                                                          0.0s
 => => sha256:5b30bfc33ca93fed51a26f6dedad278c650faf9eb6ddc752796d4e31cb4c10b1 343B / 343B                                                                                                         1.5s
 => => extracting sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1                                                                                                          0.0s
 => => extracting sha256:ad9621110251bbf75f24aaa0c4b52e0802d11bc590921015401adda364b78b19                                                                                                          0.0s
 => => extracting sha256:a69ca0ecce5760df4d789643fca9750fb31a934c16d235cb32df678cb49124a4                                                                                                          0.0s
 => => extracting sha256:5b30bfc33ca93fed51a26f6dedad278c650faf9eb6ddc752796d4e31cb4c10b1                                                                                                          0.0s
 => [2/8] COPY --chown=mambauser:mambauser env.lock /tmp/env.lock                                                                                                                                  0.0s
 => [3/8] RUN micromamba install --name base --yes --file /tmp/env.lock     && micromamba clean --all --yes                                                                                       19.8s
 => [4/8] RUN apt-get update && apt-get install -y --no-install-recommends     libgomp1     && rm -rf /var/lib/apt/lists/*                                                                         2.2s 
 => [5/8] WORKDIR /opt                                                                                                                                                                             0.0s 
 => ERROR [6/8] RUN wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/5.73-104.0/alt/interproscan-core-5.73-104.0.tar.gz &&     wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/5.73-104.  0.1s 
------                                                                                                                                                                                                  
 > [6/8] RUN wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/5.73-104.0/alt/interproscan-core-5.73-104.0.tar.gz &&     wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/5.73-104.0/alt/interproscan-core-5.73-104.0.tar.gz.md5 &&     md5sum -c interproscan-core-5.73-104.0.tar.gz.md5 &&     tar -zxf interproscan-core-5.73-104.0.tar.gz &&     rm interproscan-core-5.73-104.0.tar.gz* &&     mv /opt/interproscan-5.73-104.0 /opt/interproscan:                                                                                                                                                           
0.106 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory
------
Dockerfile:29
--------------------
  28 |     
  29 | >>> RUN wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/${VERSION}/alt/interproscan-core-${VERSION}.tar.gz && \
  30 | >>>     wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/${VERSION}/alt/interproscan-core-${VERSION}.tar.gz.md5 && \
  31 | >>>     md5sum -c interproscan-core-${VERSION}.tar.gz.md5 && \
  32 | >>>     tar -zxf interproscan-core-${VERSION}.tar.gz && \
  33 | >>>     rm interproscan-core-${VERSION}.tar.gz* && \
  34 | >>>     mv /opt/interproscan-${VERSION} /opt/interproscan
  35 |     
--------------------
ERROR: failed to solve: process "/usr/local/bin/_dockerfile_shell.sh wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/${VERSION}/alt/interproscan-core-${VERSION}.tar.gz &&     wget ftp://ftp.ebi.ac.uk/pub/software/unix/iprscan/5/${VERSION}/alt/interproscan-core-${VERSION}.tar.gz.md5 &&     md5sum -c interproscan-core-${VERSION}.tar.gz.md5 &&     tar -zxf interproscan-core-${VERSION}.tar.gz &&     rm interproscan-core-${VERSION}.tar.gz* &&     mv /opt/interproscan-${VERSION} /opt/interproscan" did not complete successfully: exit code: 255

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1287fc7

+| ✅ 199 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.1
  • Run at 2025-06-24 18:29:43

@olgabot olgabot mentioned this pull request Mar 25, 2025
11 tasks
@olgabot
Copy link
Copy Markdown
Collaborator Author

olgabot commented Mar 25, 2025

Want to update InterProScan version of nf-modules first: nf-core/modules#8003

Comment thread subworkflows/local/utils_nfcore_proteinannotator_pipeline/tests/main.nf.test Outdated
@olgabot
Copy link
Copy Markdown
Collaborator Author

olgabot commented Jun 24, 2025

Turns out the tests were "randomly" failing because the *.tsv.gz and *.gff3.gz files from InterProScan include the date of the run, which changes every time:

image

395e782 adds helper functions to replace all date strings with placeholder text like: dd-mm-yyyy

CleanShot 2025-06-24 at 11 02 07@2x

@olgabot olgabot merged commit adf3815 into dev Jun 24, 2025
19 checks passed
@vagkaratzas vagkaratzas mentioned this pull request Feb 4, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants