Skip to content

Added functional meta.yml and test #91

Merged
vagkaratzas merged 31 commits into
devfrom
add-functional-meta-and-test-2
Mar 30, 2026
Merged

Added functional meta.yml and test #91
vagkaratzas merged 31 commits into
devfrom
add-functional-meta-and-test-2

Conversation

@Muskan-2464

Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/proteinannotator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (e.g. nf-test test */local --profile=~test,docker for all new local tests).
  • Check for unexpected warnings in debug mode (nf-test test */local --profile=~test,docker,debug).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot

Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@Muskan-2464 Muskan-2464 marked this pull request as ready for review March 13, 2026 18:52

@vagkaratzas vagkaratzas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments to revise. In addition:

  1. when staging files, and before commiting them, run pre-commit locally so formatting issues are tackled there
  2. make sure nf-core subworkflows lint command passes all test for this subworkflow
  3. Run the nf-test test /path/to/test/main.nf.test --profile +singularity --verbose command twice; one to generate the snapshot, and then once more to make sure the snapshot is not changing.

Comment thread subworkflows/local/functional_annotation/meta.yml Outdated
Comment thread subworkflows/local/functional_annotation/meta.yml Outdated
Comment thread subworkflows/local/functional_annotation/meta.yml Outdated
Comment thread subworkflows/local/functional_annotation/meta.yml Outdated
Comment thread subworkflows/local/functional_annotation/tests/main.nf.test Outdated
Comment thread subworkflows/local/functional_annotation/tests/main.nf.test Outdated
Comment thread subworkflows/local/functional_annotation/tests/main.nf.test Outdated
Comment thread subworkflows/local/functional_annotation/tests/main.nf.test Outdated
Comment thread subworkflows/local/functional_annotation/tests/main.nf.test Outdated
Comment thread subworkflows/local/functional_annotation/tests/main.nf.test
Comment thread subworkflows/local/functional_annotation/tests/main.nf.test Outdated
@github-actions

github-actions Bot commented Mar 28, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 38be11c

+| ✅ 218 tests passed       |+
#| ❔   7 tests were ignored |#
Details

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-03-30 07:55:59

@vagkaratzas vagkaratzas self-requested a review March 30, 2026 07:56

@vagkaratzas vagkaratzas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thank you @Muskan-2464 :D
I made a small tweak to the input file of the main test, and also added a needed config, otherwise INTERPROSCAN would not properly execute on the GitHub runner.

@vagkaratzas vagkaratzas merged commit e4da269 into dev Mar 30, 2026
12 checks passed
@vagkaratzas vagkaratzas deleted the add-functional-meta-and-test-2 branch March 30, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants