Emphasise base.config values SHOULD be adjusted on a per-pipeline basis by developer#4360
Open
jfy133 wants to merge 1 commit into
Open
Emphasise base.config values SHOULD be adjusted on a per-pipeline basis by developer#4360jfy133 wants to merge 1 commit into
jfy133 wants to merge 1 commit into
Conversation
Updated TODO comments to clarify resource adjustments for the pipeline.
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ammaraziz
reviewed
Jun 30, 2026
| // adding in your local modules too. | ||
| // TODO nf-core: Customise requirements for specific processes. | ||
| // See https://www.nextflow.io/docs/latest/config.html#config-process-selectors | ||
| // TODO nf-core: adjust all CPU, memory, and time resource requests to work with 'average' data for the pipeline |
There was a problem hiding this comment.
I would add stronger language:
// TODO nf-core: adjust all CPU, memory, and time resource requests to work with 'average' data for the pipeline
// Default resource usage limits are intentionally generous and are may not be suitable.
// It is highly recommended to modify these settings to suit your pipeline.
jfy133
commented
Jun 30, 2026
| // adding in your local modules too. | ||
| // TODO nf-core: Customise requirements for specific processes. | ||
| // See https://www.nextflow.io/docs/latest/config.html#config-process-selectors | ||
| // TODO nf-core: adjust all CPU, memory, and time resource requests to work with 'average' data for the pipeline |
Member
Author
There was a problem hiding this comment.
Suggested change
| // TODO nf-core: adjust all CPU, memory, and time resource requests to work with 'average' data for the pipeline | |
| // TODO nf-core: adjust all CPU, memory, and time resource requests to work with 'average' data for the pipeline | |
| // Default resource usage limits are intentionally generous and are may not be suitable. | |
| // It is highly recommended to modify these settings to suit your pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated TODO comments to clarify resource adjustments for the pipeline.
PR checklist
CHANGELOG.mdis updateddocsis updated