Add TODO for module tags without metadata#4390
Open
sapunyangkut wants to merge 1 commit into
Open
Conversation
Signed-off-by: sapunyangkut <302607731+sapunyangkut@users.noreply.github.com>
sapunyangkut
marked this pull request as ready for review
July 12, 2026 02:58
Contributor
|
Hi, thanks for the contribution. Please join the github org via the slack channel so the CI runs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
"$bam"so Nextflow interpolates the variableFixes #2536.
Validation
nf_core/module-template/main.nfwith Jinja2 for both branches:has_meta=true:tag "$meta.id", no new TODOhas_meta=false: one TODO immediately beforetag "$bam".venv\Scripts\prek.exe run --config .pre-commit-config.yaml --files nf_core/module-template/main.nfgit diff --checktests/modules/test_create.pycould not reach its assertions locally because all 12 tests require a Nextflow executable during shared setup, which is unavailable in this Windows environment. No test failure was caused by the rendered template.PR checklist
CHANGELOG.mdis updated (left for the repository bot)Automation disclosure
This small template change was prepared and tested with OpenAI Codex automation. It received advisory AI reviews from an independent local agent and ChatGPT Web; both returned approval. No human review is claimed.