Fix false nf-test failure on empty stderr#4391
Open
sapunyangkut wants to merge 1 commit into
Open
Conversation
Signed-off-by: sapunyangkut <302607731+sapunyangkut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nf-test failederror when stderr is non-empty--no-promptsbehaviorThe previous bare
elsewas attached to the snapshot-difference check, so a successful interactive nf-test run with empty stderr still appended an error. Snapshot stability runs the command twice, producing the two false failures reported in the issue.Fixes #4327.
Validation
python -m pytest tests/components/test_components_snapshot_test.py -k display_nftest_output_stderr -q(3 passed)python -m py_compileon both changed Python filesgit diff --checkPR checklist
devAutomation disclosure
This small bug fix was prepared and tested with OpenAI Codex automation and independently red-teamed by a separate local agent. The contributor remains responsible for the submitted change; no human review is claimed.