Fix newsletter month seeding so the current month's issue always appears#4295
Merged
Conversation
The newsletter dated the 1st of month M reports the *previous* calendar month's content, but getNewsletterMonths seeded candidate months from the month each item was *dated in* rather than the month that *reports* it. A newsletter therefore only appeared if something happened to be dated in its own month, so the July issue (reporting June) would not show on the 1st unless unrelated July-dated content existed. Seed backward-looking content (blog posts, advisories, releases, new pipelines) from month X into the newsletter dated X+1, and events into both their own month and the previous month (matching the forward-looking "upcoming events" section). newsletterMonthHasContent still gates out any candidate whose sections would all be empty. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XUD4bQJx4nFhMGTtSqiwvK
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mashehu
approved these changes
Jul 1, 2026
mashehu
left a comment
mashehu
left a comment
Contributor
There was a problem hiding this comment.
code comments could also be a bit less wordy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newsletter dated the 1st of month M reports the previous calendar
month's content, but getNewsletterMonths seeded candidate months from the
month each item was dated in rather than the month that reports it. A
newsletter therefore only appeared if something happened to be dated in its
own month, so the July issue (reporting June) would not show on the 1st
unless unrelated July-dated content existed.
Seed backward-looking content (blog posts, advisories, releases, new
pipelines) from month X into the newsletter dated X+1, and events into both
their own month and the previous month (matching the forward-looking
"upcoming events" section). newsletterMonthHasContent still gates out any
candidate whose sections would all be empty.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01XUD4bQJx4nFhMGTtSqiwvK