Skip to content

fix: make pagination reactive to lastPage changes #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dialvarezs merged 1 commit into from
Jul 17, 2026
Merged

fix: make pagination reactive to lastPage changes #4312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 16 additions & 22 deletions sites/main-site/src/components/PaginationNav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,30 @@

let { lastPage = 1 }: Props = $props();

let pages: number[] = $state([]);
let truncatedPages: number[] = $state([]);

const maxPages = 7;
let truncated = $state(false);
let truncated = $derived(lastPage > maxPages);

function generatePages() {
pages = [];
truncatedPages = [];
truncated = lastPage > maxPages;
let pages = $derived.by(() => {
if (truncated) return [];
return Array.from({ length: lastPage }, (_, i) => i + 1);
});

if (truncated) {
const startIndex = Math.max($currentPage - Math.floor(maxPages / 2), 1);
const endIndex = Math.min(startIndex + maxPages - 1, lastPage);
let truncatedPages = $derived.by(() => {
if (!truncated) return [];
const startIndex = Math.max($currentPage - Math.floor(maxPages / 2), 1);
const endIndex = Math.min(startIndex + maxPages - 1, lastPage);
return Array.from({ length: endIndex - startIndex + 1 }, (_, i) => startIndex + i);
});

for (let i = startIndex; i <= endIndex; i++) {
truncatedPages.push(i);
}
} else {
for (let i = 1; i <= lastPage; i++) {
pages.push(i);
}
// Clamp current page if lastPage shrinks (e.g. after filtering search results)
$effect(() => {
if ($currentPage > lastPage) {
$currentPage = lastPage;
}
}
});

function handlePageChange(page) {
$currentPage = page;
generatePages();
}

function handleKeydown(e, page) {
Expand All @@ -43,8 +39,6 @@
handlePageChange(page);
}
}

generatePages();
</script>

<div class="d-flex justify-content-center mt-2">
Expand Down
Loading