Skip to content

Commit e434dd1

Browse files
committed
Remove requirement to have a certain version of loopback packages
1 parent 841e768 commit e434dd1

6 files changed

Lines changed: 133 additions & 114 deletions

File tree

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,13 @@ compared to the database version.
1818

1919
## Prerequisites
2020

21-
Some dependencies need to have at least a certain version
21+
Some dependencies need to be installed as peer dependencies
2222

2323
```sh
24-
@loopback/core >=2.8.0
25-
@loopback/repository >=2.5.0
24+
@loopback/boot
25+
@loopback/context
26+
@loopback/core
27+
@loopback/repository
2628
```
2729

2830
and the application needs to have the `RepositoryMixin` applied and to automatically discover the

package-lock.json

Lines changed: 114 additions & 94 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,19 +62,19 @@
6262
"peerDependencies": {
6363
"@loopback/boot": "*",
6464
"@loopback/context": "*",
65-
"@loopback/core": ">=2.8.0",
66-
"@loopback/repository": ">=2.5.0"
65+
"@loopback/core": "*",
66+
"@loopback/repository": "*"
6767
},
6868
"dependencies": {
6969
"compare-versions": "^3.6.0"
7070
},
7171
"devDependencies": {
72-
"@loopback/boot": "2.3.2",
72+
"@loopback/boot": "1.x.x",
7373
"@loopback/build": "6.1.0",
74-
"@loopback/context": "3.8.2",
75-
"@loopback/core": "2.9.1",
74+
"@loopback/context": "1.x.x",
75+
"@loopback/core": "1.x.x",
7676
"@loopback/eslint-config": "8.0.3",
77-
"@loopback/repository": "2.9.0",
77+
"@loopback/repository": "1.x.x",
7878
"@loopback/testlab": "3.2.0",
7979
"@types/node": "14.0.23",
8080
"coveralls": "3.1.0",

src/__tests__/unit/component.unit.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ describe("MigrationComponent (unit)", () => {
1717
it("should set all artifacts correctly", async () => {
1818
expect(migrationComponent.models).to.deepEqual([Migration]);
1919
expect(migrationComponent.repositories).to.deepEqual([MigrationRepository]);
20-
expect(migrationComponent.services).to.deepEqual([MigrationService]);
2120
expect(migrationComponent.lifeCycleObservers).to.deepEqual([MigrationObserver]);
2221
expect(migrationComponent.booters).to.deepEqual([MigrationBooter]);
22+
expect(migrationComponent.bindings[0].key).to.equal(
23+
`services.${MigrationService.name}`
24+
);
2325
});
2426
});
2527
});

src/component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, bind, ContextTags } from "@loopback/core";
1+
import { Component, bind, ContextTags, createServiceBinding } from "@loopback/core";
22
import { Migration } from "./models";
33
import { MigrationObserver } from "./observers";
44
import { MigrationRepository } from "./repositories";
@@ -10,7 +10,7 @@ import { MigrationBooter } from "./booters";
1010
export class MigrationComponent implements Component {
1111
models = [Migration];
1212
repositories = [MigrationRepository];
13-
services = [MigrationService];
1413
lifeCycleObservers = [MigrationObserver];
1514
booters = [MigrationBooter];
15+
bindings = [createServiceBinding(MigrationService)];
1616
}

0 commit comments

Comments
 (0)